Cleanup trailing slashed from FOO_SITE

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Luca" == Luca Ceresoli <[email protected]> writes:

Hi,
this small patch set cleans up the form of FOO_SITE variables by removing all trailing slashes.

Those slashes are useless and potentially armful, which led to introducing a workaround to strip them:

commit 1cbffbd015106ea90fe49e27433375769dc1035b
Author: Shawn J. Goff <[email protected]>
Date: Fri Apr 12 09:40:30 2013 +0000

eliminate double slashes caused by FOO_SITE ending in a slash

When a FOO_SITE variable ends in a slash and gets joined with a FOO_SOURCE variable like $(FOO_SITE)/$(FOO_SOURCE), the resulting URI has a double slash. While double-slashes are fine in unix paths, they are reserved in URIs - the part following '//' must be an authority.

Signed-off-by Shawn J. Goff <[email protected]>

Signed-off-by Peter Korsgaard <[email protected]>

This series removes all these slashes and the workaround, and updates the manual which is currently suggesting an incorrect URL.

This work has been inspired by this comment from Arnout Vandecappelle:

Quoted 8 lines

Quoted 3 lines

Review

Quoted 3 lines

(quoted diff) +3 -0

+else
+ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),$$($(2)_SOURCE))
+	    $(call DOWNLOAD,$$($(2)_ACTUAL_SOURCE_SITE:/=)/$$($(2)$($(PKG)_SITE:/=)_ACTUAL_SOURCE_TARBALL))

I think the $($(PKG)_SITE:/=) construct was just introduced because for some packages, the _SITE ends with a / and that should be stripped, and we were too lazy to fix the packages. Hm, looks like all the the external toolchain _SITEs end with a /...

(source: https://patchwork.ozlabs.org/patch/424980/)

Luca Ceresoli (3):
manual: download: remove trailing slash from package FOO_SITE Remove trailing slash from all package site URLs
Download: remove trailing slash cleanups for SITE URLs