Skip to content

arm: mvebu: add Synology DS213j and DS414 .dts files

Arnaud Ebalard linux-arm-kernel linux-devicetree 8 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 2/20 of 10 patches 0 repliesNew
  2. v6 posting 1/210 patches 0 repliesSuperseded
  3. v510 patches 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v410 patches0 repliesSuperseded
v3 posting 2/20 of 12 patches0 repliesSuperseded
v3 posting 1/212 patches0 repliesSuperseded
v28 patches0 repliesSuperseded
v10 of 3 patches0 repliesSuperseded

Patches in v6 posting 2/2 No applies recorded yet

None of the 10 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCHv6 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files

Hi Jason,

Sorry for the trouble w/ my patches. I'll try and avoid such issues in the future.

Quoted 9 lines · Jason Cooper
Quoted 1 line

Arnaud Ebalard (10):

These three patches had trouble:

Quoted 1 line

arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi

armada-370-db needed to be hand-jammed. Please double-check that it went through correctly. The error was something about missing repository info. Usually that means the patch was based on something weird...

After pushing v2, Sebastian's pointed there was some of the patches I had which he had already done and were sitting in your mvebu/dt banch. So I rebased my whole series on your mvebu/dt but used mvebu-dt-3.19 at some point, which was behind the tip, i.e. had not the following patches:

commit ab1e85372168892387dd1ac171158fc8c3119be4 <- your tip commit ad6a1b445bdc19199933051840a53fdd30b8f961
commit ebf50c9651ff28341b76e78c531592d7d3489bc6
commit 5e949f0c79917f3fd8512a3b66b0c861e03ec5a6
commit 9ef90cbb0860d3434fdc4bf9674adca1b762f95e
commit a6b334514be27aec1bf31c7673c2f55bd6fbd3e6
commit b4607572ef86b288a856b9df410ea593c5371dec
commit f5ed9ccc4c2dc275a13b765c88fa13211f60b57f <- mvebu-dt-3.19

Quoted 4 lines
Quoted 1 line

arm: mvebu: define and use common Armada 370 UART pinctrl settings

Same here, 'patch -Np1 <...patch' went fine, though. Please double check.

I will take a thorough look today at what you currently have in your tree (and more specifically regarding DS414) and do more tests on both NAS next week.

Quoted 4 lines
Quoted 1 line

arm: mvebu: add .dts file for Synology DS414

This broke the build :( I did s/ge[01]_rgmii_pins/pmx_ge[01]_rgmii/ to fix the issue. Did you run 'make dtbs' before you sent?

Each series was compiled and tested on the DS213j because DS414 is painful to handle (SAR issue pointed in the .dts file which requires unplugging/plugging the USB/serial + longer time to boot). The thing is when I merged the two development tres I had for the DS213j and DS414, I used the DS213j config ... which did not have CONFIG_MACH_ARMADA_XP.

Again, my apologies for the trouble and manual handling.

Quoted 1 line

At any rate, whole series applied to mvebu/dt.

Thanks,

a+