Skip to content

Simplifying siginfo users

Eric W. Biederman linux-alpha linux-api linux-arch linux-hexagon linux-ia64 linux-mips linux-parisc linux-riscv linux-s390 linux-sh linux-um linuxppc-dev lkml openrisc sparclinux stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22signal/alpha: Use send_sig_fault where appropriatearch/alpha/kernel/osf_sys.c arch/alpha/kernel/signal.c arch/alpha/kernel/traps.c+24 -790 replies
2/22signal/alpha: Use force_sig_fault where appropriatearch/alpha/kernel/traps.c arch/alpha/mm/fault.c+3 -210 replies
3/22signal/c6x: Use force_sig_fault where appropriatearch/c6x/kernel/traps.c+2 -80 replies
4/22signal/hexagon: Use force_sig_fault as appropriatearch/hexagon/kernel/traps.c arch/hexagon/mm/vm_fault.c+9 -220 replies
5/22signal/m68k: Use force_sig_fault where appropriatearch/m68k/kernel/traps.c arch/m68k/mm/fault.c+36 -490 replies
6/22signal/microblaze: Remove the commented out force_sig_info in do_page_faultarch/microblaze/mm/fault.c+0 -50 replies
7/22signal/microblaze: Use force_sig_fault where appropriatearch/microblaze/kernel/exceptions.c arch/microblaze/mm/fault.c+2 -160 replies
8/22signal/mips: Use force_sig_fault where appropriatearch/mips/kernel/traps.c arch/mips/mm/fault.c+23 -614 replies
9/22signal/nds32: Use force_sig_fault where appropriatearch/nds32/kernel/traps.c arch/nds32/mm/fault.c+9 -303 replies
10/22signal/nios2: Use force_sig_fault where appropriatearch/nios2/kernel/traps.c+1 -80 replies
11/22signal/openrisc: Use force_sig_fault where appropriatearch/openrisc/kernel/traps.c arch/openrisc/mm/fault.c+9 -430 replies
12/22signal/parisc: Use force_sig_mceerr where appropriatearch/parisc/mm/fault.c+15 -150 replies
13/22signal/parisc: Use force_sig_fault where appropriatearch/parisc/kernel/ptrace.c arch/parisc/kernel/traps.c arch/parisc/kernel/unaligned.c +2 more+39 -851 reply
14/22signal/riscv: Use force_sig_fault where appropriatearch/riscv/kernel/traps.c+1 -84 replies
15/22signal/s390: Use force_sig_fault where appropriatearch/s390/kernel/traps.c arch/s390/mm/fault.c+12 -431 reply
16/22signal/sh: Use force_sig_fault where appropriatearch/sh/kernel/traps_32.c arch/sh/math-emu/math.c arch/sh/mm/fault.c+8 -304 replies
17/22signal/sparc: Use send_sig_fault where appropriatearch/sparc/kernel/traps_32.c arch/sparc/kernel/unaligned_32.c+20 -850 replies
18/22signal/sparc: Use force_sig_fault where appropriatearch/sparc/kernel/process_64.c arch/sparc/kernel/sys_sparc_32.c arch/sparc/kernel/sys_sparc_64.c +4 more+37 -1780 replies
19/22signal/um: Use force_sig_fault in relay_signal.arch/um/kernel/trap.c+13 -1513 replies
20/22signal/um: Use force_sig_fault where appropriatearch/um/kernel/ptrace.c arch/um/kernel/trap.c+11 -280 replies
21/22signal/xtensa: Consistenly use SIGBUS in do_unaligned_userarch/xtensa/kernel/traps.c+1 -11 reply
22/22signal/xtensa: Use force_sig_fault where appropriatearch/xtensa/kernel/traps.c arch/xtensa/mm/fault.c+6 -231 reply

Reviews trailers per patch

6 of 22 patches have a Reviewed-by or Acked-by.

PatchRich FelkerMax FilippovHelge DellerMartin SchwidefskyPalmer Dabbelt
1/22
2/22
3/22
4/22
5/22
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22A-b
14/22A-b
15/22A-b
16/22A-b
17/22
18/22
19/22
20/22
21/22A-b
22/22A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [REVIEW][PATCH 00/22] Simplifying siginfo users

This patchset is almost completely updating the various pieces of architecture code from filling out a struct siginfo and then calling force_sig_info. To using the helper force_sig_fault instead. Which takes the values that would have gone in siginfo as arguments.

As the diffstat below shows this noticeable reduces the amount of code.

There are a couple of minor and straight forward bug fixes as well that I came across while working on the aforementioned changes.

This applies on my last round of siginfo changes simply to remove the possibility of conflicts. The changes should be semantically separate.

I intend to merge these changes through my siginfo tree. If you have any objections or would prefer to carry these changes in your architecture trees please let me know.

The changes are also available at:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git siginfo-review2

Eric W. Biederman (22):
signal/alpha: Use send_sig_fault where appropriate signal/alpha: Use force_sig_fault where appropriate signal/c6x: Use force_sig_fault where appropriate signal/hexagon: Use force_sig_fault as appropriate signal/m68k: Use force_sig_fault where appropriate signal/microblaze: Remove the commented out force_sig_info in do_page_fault signal/microblaze: Use force_sig_fault where appropriate signal/mips: Use force_sig_fault where appropriate signal/nds32: Use force_sig_fault where appropriate signal/nios2: Use force_sig_fault where appropriate signal/openrisc: Use force_sig_fault where appropriate signal/parisc: Use force_sig_mceerr where appropriate signal/parisc: Use force_sig_fault where appropriate signal/riscv: Use force_sig_fault where appropriate signal/s390: Use force_sig_fault where appropriate
signal/sh: Use force_sig_fault where appropriate
signal/sparc: Use send_sig_fault where appropriate signal/sparc: Use force_sig_fault where appropriate
signal/um: Use force_sig_fault in relay_signal.
signal/um: Use force_sig_fault where appropriate signal/xtensa: Consistenly use SIGBUS in do_unaligned_user signal/xtensa: Use force_sig_fault where appropriate

 arch/alpha/kernel/osf_sys.c         |  10 +--
 arch/alpha/kernel/signal.c          |  22 +-----
 arch/alpha/kernel/traps.c           |  80 +++++---------------
 arch/alpha/mm/fault.c               |  15 +---
 arch/c6x/kernel/traps.c             |  10 +--
 arch/hexagon/kernel/traps.c         |  10 +--
 arch/hexagon/mm/vm_fault.c          |  21 ++----
 arch/m68k/kernel/traps.c            |  60 +++++++--------
 arch/m68k/mm/fault.c                |  25 +++----
 arch/microblaze/kernel/exceptions.c |   9 +--
 arch/microblaze/mm/fault.c          |  14 +---
 arch/mips/kernel/traps.c            |  65 +++++-----------
 arch/mips/mm/fault.c                |  19 ++---
 arch/nds32/kernel/traps.c           |  20 +----
 arch/nds32/mm/fault.c               |  19 ++---
 arch/nios2/kernel/traps.c           |   9 +--
 arch/openrisc/kernel/traps.c        |  33 +-------
 arch/openrisc/mm/fault.c            |  19 ++---
 arch/parisc/kernel/ptrace.c         |  11 +--
 arch/parisc/kernel/traps.c          |  63 +++++-----------
 arch/parisc/kernel/unaligned.c      |  16 +---
 arch/parisc/math-emu/driver.c       |   9 +--
 arch/parisc/mm/fault.c              |  55 +++++++-------
 arch/riscv/kernel/traps.c           |   9 +--
 arch/s390/kernel/traps.c            |  32 ++------
 arch/s390/mm/fault.c                |  23 ++----
 arch/sh/kernel/traps_32.c           |  19 ++---
 arch/sh/math-emu/math.c             |   9 +--
 arch/sh/mm/fault.c                  |  10 +--
 arch/sparc/kernel/process_64.c      |  10 +--
 arch/sparc/kernel/sys_sparc_32.c    |   9 +--
 arch/sparc/kernel/sys_sparc_64.c    |   8 +-
 arch/sparc/kernel/traps_32.c        | 114 +++++-----------------------
 arch/sparc/kernel/traps_64.c        | 145 +++++++-----------------------------
 arch/sparc/kernel/unaligned_32.c    |  12 +--
 arch/sparc/mm/fault_32.c            |  13 +---
 arch/sparc/mm/fault_64.c            |   9 +--
 arch/um/kernel/ptrace.c             |  13 +---
 arch/um/kernel/trap.c               |  54 ++++++--------
 arch/xtensa/kernel/traps.c          |  10 +--
 arch/xtensa/mm/fault.c              |  19 ++---
 41 files changed, 280 insertions(+), 852 deletions(-)

Eric