Skip to content

OMAP: WDT: Implement WDT in hwmod way

Kevin Hilman linux-arm-kernel linux-omap linux-watchdog 3 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest posting 3/30 of 6 patches 0 repliesNew
  2. v8 posting 2/30 of 6 patches 0 repliesSuperseded
  3. v8 posting 1/30 of 6 patches 0 repliesSuperseded

Patches in v8 posting 3/3 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.

Read the v8 thread

Cover letter [PATCH v8 0/6] OMAP: WDT: Implement WDT in hwmod way

"Varadarajan, Charulatha" <[email protected]> writes:

[...]

Quoted 11 lines
Quoted 10 lines

Instead, I would rather have a small piece of code in omap_init_wdt() which disarms the watchdog so we don't have any assumptions about bootloader behavior.

The question remains whether this disarm should be
#ifndef CONFIG_OMAP_WATCHDOG or if it should happen all the time. In case the watchdog is a module, it's probe may not happen within the timeout period and they system may reboot also, so I lean towards disarming the watchdog unconditionally.

Quoted 3 lines

Agreed. But this shall be handled in mach-omap2/devices.c by directly accessing the watchdog registers and disabling it, as the watchdog driver would not be available by this time.

Correct.

Quoted 2 lines

If this okay, I would send a separate patch on top my hwmod series to handle this.

Yes please.

Thanks,

Kevin