Skip to content

signal/powerpc: siginfo cleanups

Eric W. Biederman linux-arch linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9signal/powerpc: Use force_sig_mceerr as appropriatearch/powerpc/mm/fault.c+11 -71 reply
2/9signal/powerpc: Remove pkey parameter from __bad_areaarch/powerpc/mm/fault.c+4 -51 reply
3/9signal/powerpc: Call _exception_pkey directly from bad_key_fault_exceptionarch/powerpc/mm/fault.c+11 -11 reply
4/9signal/powerpc: Remove pkey parameter from __bad_area_nosemaphorearch/powerpc/mm/fault.c+4 -51 reply
5/9signal/powerpc: Factor the common exception code into exception_commonarch/powerpc/kernel/traps.c+13 -51 reply
6/9signal/powerpc: Call force_sig_fault from _exceptionarch/powerpc/kernel/traps.c+4 -11 reply
7/9signal/poewrpc: Specialize _exception_pkey for handling pkey exceptionsarch/powerpc/include/asm/bug.h arch/powerpc/kernel/traps.c arch/powerpc/mm/fault.c+7 -72 replies
8/9signal/powerpc: Simplify _exception_pkey by using force_sig_pkuerrarch/powerpc/kernel/traps.c+1 -91 reply
9/9signal/powerpc: Use force_sig_fault where appropriatearch/powerpc/kernel/process.c arch/powerpc/mm/fault.c arch/powerpc/platforms/cell/spu_base.c +1 more+12 -361 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchStephen Rothwell
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [REVIEW][PATCH 0/9] signal/powerpc: siginfo cleanups

This is the continuation of my work to sort out signaling of exceptions with siginfo. The old functions by passing siginfo resulted in many cases of fields of siginfo that were not initialized and then passed to userspace, and also resulted in callers getting confused and initializing the wrong fields. My remedy is to have specific functions for sending each different kind of signal with siginfo. Those functions take the information needed to fill in siginfo and do the work themselves.

This is my set of changes to update powerpc to use those functions. Along with some refactoring so those functions can be cleanly used.

Folks please review and double check me. I think I have kept these changes simple and obviously correct but I am human and mess up sometimes.

After these patches have had a chance to be reviewed I plan to merge them by my siginfo tree. If you would rather take them in the powerpc
tree let me know. All of the prerequisites should have been merged
through Linus's tree several releases ago.

Eric W. Biederman (9):
signal/powerpc: Use force_sig_mceerr as appropriate signal/powerpc: Remove pkey parameter from __bad_area signal/powerpc: Call _exception_pkey directly from bad_key_fault_exception signal/powerpc: Remove pkey parameter from __bad_area_nosemaphore signal/powerpc: Factor the common exception code into exception_common signal/powerpc: Call force_sig_fault from _exception signal/poewrpc: Specialize _exception_pkey for handling pkey exceptions signal/powerpc: Simplify _exception_pkey by using force_sig_pkuerr signal/powerpc: Use force_sig_fault where appropriate

 arch/powerpc/include/asm/bug.h            |  2 +-
 arch/powerpc/kernel/process.c             |  9 +----
 arch/powerpc/kernel/traps.c               | 27 ++++++++-------
 arch/powerpc/mm/fault.c                   | 55 +++++++++++++++++--------------
 arch/powerpc/platforms/cell/spu_base.c    |  4 +--
 arch/powerpc/platforms/cell/spufs/fault.c | 26 +++++----------
 6 files changed, 57 insertions(+), 66 deletions(-)

Eric