Skip to content

dbus-python cleanup and python3 support

Peter Korsgaard buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH next 0/3] dbus-python cleanup and python3 support
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 10 lines

Dear Peter Korsgaard,

Quoted 4 lines · Peter Korsgaard

Peter Korsgaard (3):
dbus-python: cleanup package
python3: add patch to fix --includes / --ldflags output of python3-config
dbus-python: add python3 support

Thanks, series applied to next. Probably the first time that I apply some patches from you :-)

;)

Review

Quoted 7 lines

I found one minor issue: on the last patch, you forgot to update the dependencies of the comment, so I added the following change to your patch:

comment "dbus-python needs a toolchain w/ wchar, threads"

(quoted diff) +1 -1
-       depends on BR2_PACKAGE_DBUS && BR2_PACKAGE_PYTHON
+       depends on BR2_PACKAGE_DBUS && (BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3)

Ahh yes, thanks

Signature · 1 line
Bye, Peter Korsgaard

Read the cover letter in its thread