Skip to content

Final si_trapno bits

Eric W. Biederman linux-api linux-arch lkml sparclinux 1 version In review

Get series with b4
b4 am 87a6mnzbx2.fsf_-_@disp2133

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sparc64: Add compile-time asserts for siginfo_t offsetsarch/sparc/kernel/signal32.c arch/sparc/kernel/signal_64.c+69 -00 replies
2/6arm: Add compile-time asserts for siginfo_t offsetsarch/arm/kernel/signal.c+37 -00 replies
3/6arm64: Add compile-time asserts for siginfo_t offsetsarch/arm64/kernel/signal.c arch/arm64/kernel/signal32.c+74 -00 replies
4/6signal/sparc: si_trapno is only used with SIGILL ILL_ILLTRParch/sparc/include/uapi/asm/siginfo.h arch/sparc/kernel/process_64.c arch/sparc/kernel/sys_sparc_32.c +8 more+56 -451 reply
5/6signal/alpha: si_trapno is only used with SIGFPE and SIGTRAP TRAP_UNKarch/alpha/include/uapi/asm/siginfo.h arch/alpha/kernel/osf_sys.c arch/alpha/kernel/signal.c +4 more+41 -201 reply
6/6signal: Remove the generic __ARCH_SI_TRAPNO supportarch/mips/include/uapi/asm/siginfo.h include/linux/sched/signal.h kernel/signal.c+0 -241 reply

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid S. MillerMarco Elver
SeriesA-b A-b
1/6A-b
2/6
3/6
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] Final si_trapno bits

As a part of a fix for the ABI of the newly added SIGTRAP TRAP_PERF a si_trapno was reduced to an ordinary extention of the _sigfault case of struct siginfo.

When Linus saw the complete set of changes come in as a fix he requested that the set of changes be trimmed down to just what was necessary to fix the SIGTRAP TRAP_PERF ABI.

I had intended to get the rest of the changes into the merge window for v5.14 but I dropped the ball.

I have made the changes to stop using __ARCH_SI_TRAPNO be per architecture so they are easier to review. In doing so I found one place on alpha where I used send_sig_fault instead of send_sig_fault_trapno(... si_trapno = 0). That would not have changed the userspace behavior but it did make the kernel code less clear.

My rule in these patches is everywhere that siginfo layout calls for SIL_FAULT_TRAPNO the code uses either force_sig_fault_trapno or send_sig_fault_trapno.

And of course I have rebased and compile tested Marco's compile time assert patches.

Eric

Eric W. Biederman (3):
signal/sparc: si_trapno is only used with SIGILL ILL_ILLTRP signal/alpha: si_trapno is only used with SIGFPE and SIGTRAP TRAP_UNK
signal: Remove the generic __ARCH_SI_TRAPNO support

Marco Elver (3):
sparc64: Add compile-time asserts for siginfo_t offsets
arm: Add compile-time asserts for siginfo_t offsets
arm64: Add compile-time asserts for siginfo_t offsets

 arch/alpha/include/uapi/asm/siginfo.h |  2 --
 arch/alpha/kernel/osf_sys.c           |  2 +-
 arch/alpha/kernel/signal.c            |  4 +--
 arch/alpha/kernel/traps.c             | 26 +++++++++---------
 arch/alpha/mm/fault.c                 |  4 +--
 arch/arm/kernel/signal.c              | 37 +++++++++++++++++++++++++
 arch/arm64/kernel/signal.c            | 37 +++++++++++++++++++++++++
 arch/arm64/kernel/signal32.c          | 37 +++++++++++++++++++++++++
 arch/mips/include/uapi/asm/siginfo.h  |  2 --
 arch/sparc/include/uapi/asm/siginfo.h |  3 --
 arch/sparc/kernel/process_64.c        |  2 +-
 arch/sparc/kernel/signal32.c          | 35 +++++++++++++++++++++++
 arch/sparc/kernel/signal_64.c         | 34 +++++++++++++++++++++++
 arch/sparc/kernel/sys_sparc_32.c      |  2 +-
 arch/sparc/kernel/sys_sparc_64.c      |  2 +-
 arch/sparc/kernel/traps_32.c          | 22 +++++++--------
 arch/sparc/kernel/traps_64.c          | 44 +++++++++++++----------------
 arch/sparc/kernel/unaligned_32.c      |  2 +-
 arch/sparc/mm/fault_32.c              |  2 +-
 arch/sparc/mm/fault_64.c              |  2 +-
 include/linux/sched/signal.h          | 11 ++------
 kernel/signal.c                       | 52 ++++++++++++++++++++++++++---------
 22 files changed, 276 insertions(+), 88 deletions(-)