Skip to content

nsenter review comment fixes.

Eric W. Biederman util-linux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nsenter: Enhance waiting for a child processsys-utils/nsenter.c+35 -130 replies
2/5nsenter: Properly spell significant in a comment.sys-utils/nsenter.c+1 -10 replies
3/5nsenter: Add const to declarations where possible.sys-utils/nsenter.c+3 -30 replies
4/5nsenter: Replace a bare strtoul with strtoul_or_errsys-utils/nsenter.c+2 -80 replies
5/5unshare,nsenter: Move the old libc handling into a common header namespace.hinclude/namespace.h sys-utils/nsenter.c sys-utils/unshare.c+45 -550 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] nsenter review comment fixes.

Fair enough review comments all. Here are my tested incremental fixes.

 include/namespace.h |   43 +++++++++++++++++++++++
 sys-utils/nsenter.c |   94 +++++++++++++++++++++++----------------------------
 sys-utils/unshare.c |   29 +---------------
 3 files changed, 86 insertions(+), 80 deletions(-)

Eric W. Biederman (5):
nsenter: Enhance waiting for a child process
nsenter: Properly spell significant in a comment.
nsenter: Add const to declarations where possible.
nsenter: Replace a bare strtoul with strtoul_or_err unshare,nsenter: Move the old libc handling into a common header namespace.h