Skip to content

RFC Shrink clock data utilizing preprocessor

Kevin Hilman linux-arm-kernel linux-omap 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest0 of 2 patches 0 repliesNew
  2. v1 RFC1 patch 0 repliesSuperseded

Patches in v2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/2] [RFC] Shrink clock data utilizing preprocessor
Quoted 6 lines · Vladimir Zapolskiy

This change shows a possibility to utilize C preprocessor to remove redundant data from clock definitions for OMAP4 architecture.

If the change is evaluated as a positive one, the same approach could be applied in reducing LOCs from other files, which contain monotonous data enumeration.

Now that I can apply these patches and look at the result, I still have the same opinion. For me, this results in a major loss of readability.

Changes just to make nice diffstats are fine, but not when it impacts readability, etc. Especially since this data will likely be eventually moved to device tree, I'd rather see consolidation efforts focused elsewhere.

Kevin