Fix fill_files_note
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | coredump: Move definition of struct coredump_params into coredump.hinclude/ include/ | +12 | 0 replies | |
| 2/5 | coredump: Snapshot the vmas in do_coredumpfs/ fs/ fs/ +1 more | +36 | 2 replies | |
| 3/5 | coredump: Remove the WARN_ON in dump_vma_snapshotfs/ | +0 | 1 reply | |
| 4/5 | coredump/elf: Pass coredump_params into fill_note_infofs/ | +11 | 1 reply | |
| 5/5 | coredump: Use the vma snapshot in fill_files_notefs/ fs/ include/ | +33 | 2 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kees Cook | Jann Horn |
|---|---|---|
| Series | R-b | |
| 1/5 | ||
| 2/5 | R-b | |
| 3/5 | R-b | |
| 4/5 | R-b | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] Fix fill_files_note
Matthew Wilcox has reported that a missing mmap_lock in file_files_note, which could cause trouble.
Refactor the code and clean it up so that the vma snapshot makes it to fill_files_note, and then use the vma snapshot in fill_files_note.
Folks please review this as this looks correct to me but I haven't done anything beyond compile testing this yet.
Eric W. Biederman (5):
coredump: Move definition of struct coredump_params into coredump.h
coredump: Snapshot the vmas in do_coredump
coredump: Remove the WARN_ON in dump_vma_snapshot coredump/elf: Pass coredump_params into fill_note_info
coredump: Use the vma snapshot in fill_files_note
fs/binfmt_elf.c | 61 ++++++++++++++++++++++-------------------------- fs/binfmt_elf_fdpic.c | 18 +++++--------- fs/coredump.c | 55 +++++++++++++++++++++++++++++-------------- include/linux/binfmts.h | 13 +---------- include/linux/coredump.h | 20 ++++++++++++---- 5 files changed, 88 insertions(+), 79 deletions(-)
Eric