Skip to content

Fix fill_files_note

Eric W. Biederman linux-fsdevel linux-mm lkml llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5coredump: Move definition of struct coredump_params into coredump.hinclude/linux/binfmts.h include/linux/coredump.h+12 -130 replies
2/5coredump: Snapshot the vmas in do_coredumpfs/binfmt_elf.c fs/binfmt_elf_fdpic.c fs/coredump.c +1 more+36 -442 replies
3/5coredump: Remove the WARN_ON in dump_vma_snapshotfs/coredump.c+0 -51 reply
4/5coredump/elf: Pass coredump_params into fill_note_infofs/binfmt_elf.c+11 -111 reply
5/5coredump: Use the vma snapshot in fill_files_notefs/binfmt_elf.c fs/coredump.c include/linux/coredump.h+33 -102 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKees CookJann Horn
SeriesR-b
1/5
2/5R-b
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Fix fill_files_note

Matthew Wilcox has reported that a missing mmap_lock in file_files_note, which could cause trouble.

Refactor the code and clean it up so that the vma snapshot makes it to fill_files_note, and then use the vma snapshot in fill_files_note.

Folks please review this as this looks correct to me but I haven't done anything beyond compile testing this yet.

Eric W. Biederman (5):
coredump: Move definition of struct coredump_params into coredump.h
coredump: Snapshot the vmas in do_coredump
coredump: Remove the WARN_ON in dump_vma_snapshot coredump/elf: Pass coredump_params into fill_note_info
coredump: Use the vma snapshot in fill_files_note

 fs/binfmt_elf.c          | 61 ++++++++++++++++++++++--------------------------
 fs/binfmt_elf_fdpic.c    | 18 +++++---------
 fs/coredump.c            | 55 +++++++++++++++++++++++++++++--------------
 include/linux/binfmts.h  | 13 +----------
 include/linux/coredump.h | 20 ++++++++++++----
 5 files changed, 88 insertions(+), 79 deletions(-)

Eric