ARM: OMAP4: core retention support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest posting 3/30 of 8 patches 0 repliesNew
- v9 posting 2/31 of 8 patches 0 repliesSuperseded
- v9 posting 1/32 of 8 patches 0 repliesSuperseded
Patches in v9 posting 3/3 No applies recorded yet
None of the 8 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.
Cover letter [PATCHv9 0/8] ARM: OMAP4: core retention support
Quoted 52 lines · Tero Kristo
Quoted 51 lines · Kevin Hilman
Quoted 29 lines · Tero Kristo
Hi Kevin,
Quoted 26 lines · Kevin Hilman
Hi Tero,
Quoted 10 lines · Tero Kristo
Hi,
Changes compared to previous version:
- rebased on top of 3.7-rc1
- applies on top of latest func pwrst code (v6)
- added back patch #1 to this set (it wasn't queued yet after all)
- added patch #7 for fixing a bug in the functional pwrst code
- added patch #8 for fixing a regression with MUSB PHY power handling (not quite sure if this is the correct way to fix this or not)Quoted 6 lines
Tested with omap4460 gp panda + omap4430 emu blaze boards, with cpuidle + suspend.
Branch also available here:
git://gitorious.org/~kristo/omap-pm/omap-pm-work.git
branch: mainline-3.7-rc1-omap4-ret-v9I tested this branch on 4430/Panda and 4460/Panda-ES and I'm seeing several domains not hitting target power state in suspend[1].
Am I missing some other fixes? Using
omap2plus_defconfig, I tried your branch alone, and merged with v3.7-rc4, and I get the same errors.[...]
Quoted 10 lines
This looks like a combination of boot loader/kernel problems. My guess is that l3init is probably held on by the USB, and both ivahd / tesla are held on by some DSP/IVA modules which are not idling properly.
The last patch in this set should fix the USB problems at least partially, but also the USB DPLL itself might be in wrong state, attached patch might help for that one and get l3init to idle.
For DSP I don't have a patch right now, what is the boot loader you are using? (Can you provide git / commit / config info?)
I was using mainline u-boot at tag v2012.04.01 when I saw the errors.
To check the bootloader, I upgraded to the latest mainline tag (v2012.10) and the problems are gone on both 4430/Panda and
4460/Panda-ES... Interesting.
Quoted 8 lines
Quoted 2 lines
That suggests that there's still some kernel assumptions/dependencies on the bootloader that need to be addressed.
After a little bit of looking into this, this is pretty similar to what I was working on quite a while back once I tried to get the core ret work with mainline kernel. I ended up sending patches against the boot-loader as there wasn't a readily visible solution to some of the issues on kernel side => so now if you update the u-boot, it gets fixed.
Yes, recent u-boots have become much more sane in what they initialze. Now, there is a bare set of "essential" clocks/pads that are configured, so that probably explains why things work better with a sane bootloader.
Kevin
Quoted 13 lines
I am seeing (at least) following subsystems being non-idle with the old bootloader:
- M3 cortex (stuck in transition)
- DSP (stuck in transition)
- SL2IF (stuck in transition)
- FSUSB (stuck in transition)...but I am not aware of any way to get these to working properly from this state without POR. Some of them probably require firmware to be loaded and letting them out of reset also (M3 / DSP.) Benoit, do you have any clues?
-Tero