netpoll: Cleanup received packet processing
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | netpoll: Pass budget into poll_napinet/ | +3 | 0 replies | |
| 2/9 | netpoll: Visit all napi handlers in poll_napinet/ | +0 | 0 replies | |
| 3/9 | netpoll: Warn if more packets are processed than are budgetednet/ | +1 | 0 replies | |
| 4/9 | netpoll: Add netpoll_rx_processinginclude/ net/ | +16 | 0 replies | |
| 5/9 | netpoll: Don't drop all received packets.include/ net/ | +7 | 0 replies | |
| 6/9 | netpoll: Move netpoll_trap under CONFIG_NETPOLL_TRAPinclude/ net/ | +18 | 0 replies | |
| 7/9 | netpoll: Consolidate neigh_tx processing in service_neigh_queuenet/ | +16 | 0 replies | |
| 8/9 | netpoll: Move all receive processing under CONFIG_NETPOLL_TRAPinclude/ net/ | +104 | 0 replies | |
| 9/9 | netpoll: Remove dead packet receive code (CONFIG_NETPOLL_TRAP)drivers/ include/ include/ +2 more | +2 | 0 replies |
Reviews trailers per patch
1 of 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Eric Dumazet |
|---|---|
| Series | A-b A-b |
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] netpoll: Cleanup received packet processing
This is the long-winded, careful, and polite version of removing the netpoll receive packet processing.
First I untangle the code in small steps. Then I modify the code to not force reception and dropping of packets when we are transmiting a packet with netpoll. Finally I move all of the packet reception under CONFIG_NETPOLL_TRAP and delete CONFIG_NETPOLL_TRAP.
If someone wants to do a stable backport it would take backporting the first 18 patches that handle the budget == 0 in the networking drivers, and the first 5 of these patches.
If anyone wants to resurrect netpoll packet reception someday it should just be a matter of reverting the last patch.
Eric W. Biederman (9):
netpoll: Pass budget into poll_napi
netpoll: Visit all napi handlers in poll_napi
netpoll: Warn if more packets are processed than are budgeted
netpoll: Add netpoll_rx_processing
netpoll: Don't drop all received packets.
netpoll: Move netpoll_trap under CONFIG_NETPOLL_TRAP
netpoll: Consolidate neigh_tx processing in service_neigh_queue
netpoll: Move all receive processing under CONFIG_NETPOLL_TRAP
netpoll: Remove dead packet receive code (CONFIG_NETPOLL_TRAP)
drivers/net/Kconfig | 5 - include/linux/netdevice.h | 17 -- include/linux/netpoll.h | 61 ------ net/core/dev.c | 11 +- net/core/netpoll.c | 488 +-------------------------------------------- 5 files changed, 5 insertions(+), 577 deletions(-)
Eric