Skip to content

xorg: fix imput drivers install paths

Peter Korsgaard buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 6 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/6] xorg: fix imput drivers install paths
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hello All!
This series fixes the install paths of the few remaining input drivers that incorrectly installed headers in $(TARGET_DIR)/$(STAGING_DIR).

Quoted 7 lines

The underlying issue is that xorg defines an "sdkdir" pkg-config variable, as the location to find/install headers. This location is an absolute path to the staging dir (aka sysroot), but headers are installed in $(DESTDIR)/$(sdkdir).

We fix that by entirely ditching the use of sdkdir, as was done in all other xorg dirvers, with the 5 first patches of the series.

Sounds sensible to me. Did you try proposing the patches upstream?

Quoted 3 lines

Additionally, to catch such situation, the 6th and last patch of the series checks no such paths are present, neither in target/ nor in staging/ .

This seems to overlap with the checks Samuel is adding,
E.G. TARGET_DIR/STAGING_DIR are subdirs of the host build directory, so that check should catch these issues as well.

Signature · 1 line
Bye, Peter Korsgaard