net_sched: Remove broken tc actions
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | net_sched: Remove broken act_skbeditinclude/ include/ include/ +3 more | +0 | 0 replies | |
| 2/2 | net_sched: Remove broken act_simpleinclude/ include/ include/ +3 more | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] net_sched: Remove broken tc actions
While auditing the code to make certain it would be safe to enable the user namespace root to use tc actions I stumbled on the strange fact that two of the tc modules in the kernel have been broken for more years than I care to think about.
In particular neither of these two modules implements the tc_action_ops lookup method. Which means that in practice neither RTM_GETACTION nor RTM_DELACTION work. And with RTM_DELACTION broken that looks like a permanent leak of kernel memory to me.
A leak I am not happy at root having and certainly not something I want to allow unprivileged users access to.
On the premise that 5+ years is too long to wait for someone to notice, complain and get this code fixed let's just remove these broken tc modules.
Eric W. Biederman (2):
net_sched: Remove broken act_skbedit
net_sched: Remove broken act_simple
include/net/tc_act/tc_defact.h | 14 -- include/net/tc_act/tc_skbedit.h | 36 ----- include/uapi/linux/tc_act/Kbuild | 2 - include/uapi/linux/tc_act/tc_defact.h | 19 --- include/uapi/linux/tc_act/tc_skbedit.h | 46 ------- net/sched/Kconfig | 25 ---- net/sched/Makefile | 2 - net/sched/act_simple.c | 225 -------------------------------- net/sched/act_skbedit.c | 224 ------------------------------- 9 files changed, 0 insertions(+), 593 deletions(-)