Skip to content

RFC Introduce .get_voltage callback into voltdm

Kevin Hilman linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 of 5 patches 0 repliesNew

2 of 5 patches are in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ARM: omap: vc: replace data_shift with data_mask+0 -00 replies
3/5ARM: omap: vc: .get_voltage callback+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][PATCH 0/5] Introduce .get_voltage callback into voltdm

Hi Mike,

Quoted 6 lines · Mike Turquette

From: Mike Turquette <[email protected]>

This series creates a new callback for struct voltagedomain, .get_voltage. This fetches the voltage from hardware, if possible, and returns it to the caller. We use this call to populate voltdm->nominal_volt at boot time.

I pointed out a couple nitpicky things on individual patches, but otherwise this direction and motiviation for this series looks OK by me.

Just some minor comments about the structure of the series. I tend to prefer combining the introduction of a new function with it's usage. It makes review and understanding much easier, IMO. If there are reasons to keep them separate, that's fine too. Just describe the reasons in the cover letter.

Thanks,

Kevin

Read the cover letter in its thread