posix-cpu-timers: Use pids not tasks in lookup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | posix-cpu-timers: Extend rcu_read_lock removing task_struct referenceskernel/ | +23 | 0 replies | |
| 2/3 | posix-cpu-timers: Replace cpu_timer_pid_type with clock_pid_typekernel/ | +4 | 0 replies | |
| 3/3 | posix-cpu-timers: Replace __get_task_for_clock with pid_for_clockkernel/ | +30 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH v1 0/3] posix-cpu-timers: Use pids not tasks in lookup
The current posix-cpu-timer code uses pids when holding persistent references in timers. However the lookups from clockid_t still return tasks that need to be converted into pids for use.
This results in usage being pid->task->pid and that can race with release_task and de_thread. This can lead to some not wrong but surprising results. Surprising enough that Oleg and I both thought there were some bugs in the code for a while.
This set of changes modifies the code to just lookup, verify, and return pids from the clockid_t lookups to remove those potentialy troublesome races.
Eric W. Biederman (3):
posix-cpu-timers: Extend rcu_read_lock removing task_struct references
posix-cpu-timers: Replace cpu_timer_pid_type with clock_pid_type
posix-cpu-timers: Replace __get_task_for_clock with pid_for_clock
kernel/time/posix-cpu-timers.c | 102 ++++++++++++++++++----------------------- 1 file changed, 45 insertions(+), 57 deletions(-)
---
The changes can also be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git proc-testing