Skip to content

ARM: OMAP2+: PM: introduce the power domains functional states

Kevin Hilman linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v6 Latest3 of 7 patches 0 repliesNew

3 of 7 patches are in this archive. The cover letter announces 7.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/7ARM: OMAP2+: PM: use power domain functional state in stats counters+0 -00 replies
5/7ARM: OMAP2+: PM debug: trace the functional power domains states+0 -02 replies
7/7ARM: OMAP2+: PM: reorganize the powerdomain API in public and private parts+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/7] ARM: OMAP2+: PM: introduce the power domains functional states
Quoted 17 lines · Jean Pihet

Here is a re-spin after some comments and suggestions after review and discussions.

Implement the functional states for the power domains:
- unify the API to use the functional states. The new API consists of the pwrdm_set*_fpwrst and pwrdm_read*_fpwrst functions and is the API to use to control the power domains power and logic states,
- reorganize the powerdomain API in internal and external parts, in powerdomain.h [1]
- protect the power domain state change by a lock in the functions that read and set the powerdomains next functional state,
- introduce the functional states for power domains power states and logic power states [2], and the conversion functions between the functional and internal states. The conversion functions are lightweight and generic. The power domains allowed states [3] are defined in the pwrsts and pwrsts_logic_ret fields of the struct

Quoted 8 lines

powerdomain,
- program the logic power state of power domains from the functional states, in pwrdm_set*_fpwrst
- convert the OMAP2/3/4 PM code to use the updated API,
- provide the power domains statistics by functional states,
- provide ftrace tracepoints with the functional state,
- provide error logs in critical code, which makes the development easier.

I just gave this series a round of PM testing. I tested retention and off in idle & suspend, with and without CPUidle on 3430/n900, 3530/Overo, 3730/OveroSTORM, 3730/Beagle-xM and 4430/Panda (though only MPU/CPU ret/off is supported for OMAP4 in mainline.)

All PM tests passed with flying colors. Nice!

Kevin