Skip to content

rk3399 (Pinebook pro) EDP support

Arnaud Patard (Rtp) u-boot 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 0 repliesNew
  2. v39 patches 0 repliesSuperseded
  3. v210 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v10 of 8 patches0 repliesSuperseded

Changes in v4 from the cover letter

- Fix typos
- Remove plat->base change. The plat->base modification was more to get a predictible framebuffer address.
- Fix debug format patch to use 0x%ld

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9rockchip: video: vop: Use endpoint compatible string to find VOP modearch/arm/include/asm/arch-rockchip/vop_rk3288.h drivers/video/rockchip/rk_vop.c+24 -160 replies
2/9rockchip: video: edp: Add rk3399 supportarch/arm/include/asm/arch-rockchip/edp_rk3288.h drivers/video/rockchip/rk_edp.c+68 -220 replies
3/9Rockchip: video: edp: Change interrupt polarity configurationarch/arm/include/asm/arch-rockchip/edp_rk3288.h+3 -10 replies
4/9Rockchip: video: vop: Reserve efi fb memorydrivers/video/rockchip/rk_vop.c+7 -00 replies
5/9rockchip: Pinebook Pro: Enable edparch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi+4 -00 replies
6/9rockchip: pwm: Fix default polaritydrivers/pwm/rk_pwm.c+1 -10 replies
7/9rockchip: video: vop: Fix format of fbbase in debug stringdrivers/video/rockchip/rk_vop.c+1 -10 replies
8/9rockchip: video: edp: Add missing reset supportdrivers/video/rockchip/rk_edp.c+22 -00 replies
9/9rockchip: video: vop: Add reset supportdrivers/video/rockchip/rk_vop.c+47 -30 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by.

PatchPeter Robinson
1/9T-b
2/9T-b
3/9T-b
4/9T-b
5/9T-b
6/9T-b
7/9T-b
8/9T-b
9/9T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [patch v4 0/9] rk3399 (Pinebook pro) EDP support

This patchset add support for the rk3399 eDP. It has been tested on the pinebook pro and Google Kevin chromeos devices.

The changes have been written by studying the linux code, since I didn't find any manual for theses part of the RK3399 SoC.

On the linux kernel side, on recent kernels, it needs commit "pwm: rockchip: Keep enabled PWMs running while probing" otherwise the pinebook pro will freeze when probing the display.

Changes since v3:
- Fix typos
- Remove plat->base change. The plat->base modification was more to get a predictible framebuffer address.
- Fix debug format patch to use 0x%ld

Changes since v2:
- Respect alphabetical order in uboot.dtsi in patch "rk3399-pinebook-pro-u-boot.dtsi: Enable edp"
- drop "configs/pinebook-pro-rk3399_defconfig: enable SYS_USB_EVENT_POLL_VIA_INT_QUEUE" (pbp_defconfig_usb_poll.patch) patch, since the same change has been merged with change
https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip/-/commit/b197c934b11f611dcc1a083d90e68019d1e010cf
- change patch subjects.

Changes since v1:
- Add reset support for the VOP and eDP. This was needed and it appears to also solve the issue with warm reset.
- Fix a debug string in the vop driver
- Drop the patch "drivers/video/rockchip/rk_edp.c: Change clock rate".
- Address various comments