Beginning of multi-rail support for drivers/staging/lustre
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 34 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 34 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Doug Oucharek | Olaf Weber |
|---|---|---|
| Series | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [lustre-devel] [PATCH 00/34] Beginning of multi-rail support for drivers/staging/lustre
Quoted 49 lines · James Simmons
Quoted 21 lines
The following series implements the first patch in the multi-rail series:
Commit:8cbb8cd3e771("LU-7734 lnet: Multi-Rail local NI split")I split that commit up into 40 individual commits which can be found at
https://github.com/neilbrown/lustre/commits/multirail
though you need to scroll down a bit, as that contains all the multi-rail series.I then ported most of these patches to my mainline tree. Some that I haven't included are:
- lnet: Move lnet_msg_alloc/free down a bit. lnet_msg_alloc/free don't exist any more
- lnet: lib-types: change some tabs to spaces
- lnet - assorted whitespace changes.
- lnet: changeni_last_alivefromtime64_tto long
- lnet: addlnet_net_state
net_stateis never used.
- lnet: remove 'static' fromlnet_get_net_config()Quoted 9 lines
I've also made a couple of minor changes to individual patches not strictly related to porting (the
net_priofield is never used, so I never added it - I should have made that a separate patch).This series compiles, but doesn't work. I get a NULL pointer reference, then an assertion failure. If I fix those, it hangs. The NULL pointer ref and the failing assertion are gone with later patches, so I hope the other problems are too.
I have tried it and did a compare to what landed in the OpenSFS branch. I saw the failures in my testing and foudn the mistake in the 7th patch.
Quoted 4 lines
Some of these patches have very poor descriptions, such as "I have no idea what this does". If someone would like to explain - or maybe say "Oh, we really shouldn't have done that", I'd be very happy to receive that, and update the description or patch accordingly.
When I ran checkpatch it really dislikes:
This is part of
8cbb8cd3e771e7f7e0f99cafc19fad32770dc015
LU-7734 lnet: Multi-Rail local NI splitI don't recommend landing the above in the commit messsage as for the reason that a person outside of lustre will not know where to look for that git commit. Instead I recommend replacing it with:
Quoted 7 lines
------------------------------------------------------------------
Signed-off-by Amir Shehata <[email protected]>WC-bug-id: https://jira.whamcloud.com/browse/LU-7734
Reviewed-on: http://review.whamcloud.com/18274Reviewed-by Doug Oucharek <[email protected]>Reviewed-by Olaf Weber <[email protected]>Signed-off-by NeilBrown <[email protected]>
Thanks for the suggestion. I don't like that approach exactly because it seems to be a lie. The specific patch was not reviewed by those people, and there is useful information which is not included there. I have changed to patches to include:
This is part of
Commit: 8cbb8cd3e771 ("LU-7734 lnet: Multi-Rail local NI split")
from upstream lustre, where it is marked:
WC-bug-id: https://jira.whamcloud.com/browse/LU-7734
Reviewed-on: http://review.whamcloud.com/18274
checkpatch is not happy with the indented tags, but checkpatch is a servant, not the master.
I've made that change, moved this series to my 'lustre' branch, merged in the latest -rc, and pushed it all out.
Now the post the rest of the 'MR' series, and then start looking at Dynamic Discovery (756abb9cf00b9^..1c45d9051764)
Thanks,
NeilBrown
Quoted 87 lines
This gives the reviewer a URL link for both the JIRA ticket that usually contains details not in the commit message as well as the gerrit URL for the original patch. This way if a future bug is found a comparison can be done against the original patch.
The policy for the Lustre project is to perserve authorship for patches when porting to other branches, upstream or LTS.
Quoted 78 lines
These will all appear in my lustre-testing branch, but won't migrate to 'lustre' until I, at least, have enough other patches that I can get a successful test run.
Review and comments always welcome.
Thanks,
NeilBrown---
Amir Shehata (1):
Completely re-writelnet_parse_networks().NeilBrown (33):
structlnet_ni- reformat comments.
lnet: Create structlnet_net
lnet: structlnet_ni: moveni_lndtolnet_net
lnet: embedlnd_tunablesinlnet_ni
lnet: begin separating "networks" from "network interfaces".
lnet: store separate xmit/recv net-interface in each message.
lnet: changelnet_peerto reference the net, rather than ni.
lnet: add cpt tolnet_match_info.
lnet: add list of cpts tolnet_net.
lnet: add ni arg tolnet_cpt_of_nid()
lnet: pass tun tolnet_startup_lndni, instead of full conf
lnet: splitlnet_startup_lndni
lnet: reverse order of lnet_startup_lnd{net,ni}
lnet: renamelnet_find_net_lockedtolnet_find_rnet_locked
lnet: extend zombie handling to nets and nis
lnet:lnet_shutdown_lndnets- remove some cleanup code.
lnet: movelnet_shutdown_lndnetsdown to after first use
lnet: addni_state
lnet: simplifylnet_islocalnet()
lnet: discardni_cpt_list
lnet: addnet_ni_added
lnet: don't take reference inlnet_XX2ni_locked()
lnet: don't need lock to testln_shutdown.
lnet: don't take lock overlnet_net_unique()
lnet: swap 'then' and 'else' branches inlnet_startup_lndnet
lnet: only validlnd_typewhennet_idis unique.
lnet: make it possible to add a new interface to a network
lnet: add checks to ensure network interface names are unique.
lnet: track tunables inlnet_startup_lndnet()
lnet: fix typo
lnet:lnet_dyn_add_ni: fixping_infocount
lnet:lnet_dyn_del_ni: fixping_infocount
lnet: introduceuse_tcp_bondingmod param.../staging/lustre/include/linux/lnet/lib-lnet.h | 31 - .../staging/lustre/include/linux/lnet/lib-types.h | 142 ++- .../lustre/include/uapi/linux/lnet/lnet-dlc.h | 18 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 10 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 6 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 12 .../lustre/lnet/klnds/o2iblnd/o2iblnd_modparams.c | 74 +- .../staging/lustre/lnet/klnds/socklnd/socklnd.c | 25 - drivers/staging/lustre/lnet/lnet/acceptor.c | 8 drivers/staging/lustre/lnet/lnet/api-ni.c | 939 +++++++++++++------- drivers/staging/lustre/lnet/lnet/config.c | 688 +++++++++++---- drivers/staging/lustre/lnet/lnet/lib-move.c | 132 ++- drivers/staging/lustre/lnet/lnet/lib-ptl.c | 6 drivers/staging/lustre/lnet/lnet/lo.c | 2 drivers/staging/lustre/lnet/lnet/net_fault.c | 3 drivers/staging/lustre/lnet/lnet/peer.c | 31 - drivers/staging/lustre/lnet/lnet/router.c | 51 + drivers/staging/lustre/lnet/lnet/router_proc.c | 24 - drivers/staging/lustre/lnet/selftest/brw_test.c | 2 drivers/staging/lustre/lnet/selftest/framework.c | 3 drivers/staging/lustre/lnet/selftest/selftest.h | 2 21 files changed, 1507 insertions(+), 702 deletions(-)--
Signature
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20180924/ce3ab1c5/attachment.sig>