Skip to content

netpoll: Cleanups and fixes

Eric W. Biederman netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyIn review
  2. v16 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6netpoll: Remove gfp parameter from __netpoll_setupdrivers/net/bonding/bond_main.c drivers/net/team/team.c include/linux/netdevice.h +6 more+29 -340 replies
2/6netpoll: Only call ndo_start_xmit from a single placenet/core/netpoll.c+36 -250 replies
3/6netpoll: Move rx enable/disable into __dev_close_manynet/core/dev.c+4 -90 replies
4/6netpoll: Rename netpoll_rx_enable/disable to netpoll_poll_disable/enableinclude/linux/netpoll.h net/core/dev.c net/core/netpoll.c+12 -120 replies
5/6netpoll: Remove strong unnecessary assumptions about skbsnet/core/netpoll.c+2 -20 replies
6/6netpoll: Respect NETIF_F_LLTXinclude/linux/netdevice.h net/core/netpoll.c+10 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] netpoll: Cleanups and fixes

This should be a small set of safe cleanups and fixes to netpoll.

The fixes are vlan headers are now always inserted when needed, and napi polling is always avoided when network devices are closed.

There are a bunch of little cleanups removing unnecessary code, fixing function naming, not taking unnecessary locks and removing general silliness.

Eric W. Biederman (6):
netpoll: Remove gfp parameter from __netpoll_setup
netpoll: Only call ndo_start_xmit from a single place
netpoll: Move rx enable/disable into __dev_close_many
netpoll: Rename netpoll_rx_enable/disable to netpoll_poll_disable/enable
netpoll: Remove strong unnecessary assumptions about skbs
netpoll: Respect NETIF_F_LLTX

 drivers/net/bonding/bond_main.c |  6 +--
 drivers/net/team/team.c         | 16 ++++----
 include/linux/netdevice.h       |  8 +++-
 include/linux/netpoll.h         | 10 ++---
 net/8021q/vlan_dev.c            |  7 ++--
 net/bridge/br_device.c          | 15 ++++---
 net/bridge/br_if.c              |  2 +-
 net/bridge/br_private.h         |  4 +-
 net/core/dev.c                  | 17 +++-----
 net/core/netpoll.c              | 91 +++++++++++++++++++++++------------------
 10 files changed, 91 insertions(+), 85 deletions(-)