Skip to content

gpio/omap: remaining cleanups and fix

Kevin Hilman linux-arm-kernel linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] gpio/omap: remaining cleanups and fix
Quoted 37 lines · Grant Likely
Quoted 21 lines · Tarun Kanti DebBarma

Here are the remaining cleanup patches. There are broadly two categories of cleanups.

Cat-1: Those missed while introducing new feature like SPARSE_IRQ
handling and DT support; use edge/level handlers from generic IRQ framework.

Cat-2: Removal of redundant fields from struct gpio_bank{} as a
result of they being already covered by members within context field of struct gpio_bank{}.

Reference: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Commit: 66f75a5d028beaf67c931435fdc3e7823125730c (Linux 3.4-rc4)

Series is available for reference here:
git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev.git for_3.5/gpio_more_cleanup_fixes

Test info:
OMAP2+ platforms: OMAP2430SDP, OMAP3430SDP, OMAP4430SDP
OMAP1: Bootup test on OMAP1710SDP.

Quoted 14 lines

Cc: Kevin Hilman <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: Santosh Shilimkar <[email protected]>
Cc: Cousson, Benoit <[email protected]>
Cc: Grant Likely <[email protected]>
Tarun Kanti DebBarma (8):
gpio/omap: remove virtual_irq_start variable
gpio/omap: remove saved_fallingdetect, saved_risingdetect gpio/omap: remove suspend_wakeup field from struct gpio_bank gpio/omap: remove saved_wakeup field from struct gpio_bank gpio/omap: remove retrigger variable in gpio_irq_handler gpio/omap: remove suspend/resume callbacks
gpio/omap: remove cpu_is_omapxxxx() checks from *_runtime_resume() gpio/omap: fix missing check in *_runtime_suspend()

Quoted 2 lines

The changes look fine to me. Which branch should this series be merged through? It can either go via arm-soc or my gpio/next branch.

This needs a little more review/testing on OMAP.

Expect a pull request from me when it's ready and you can take it through gpio/nex.

Thanks,

Kevin

Read the cover letter in its thread