virtio_add_buf replacement.
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | virtio_ring: virtqueue_add_sgs, to add multiple sgs.drivers/ include/ tools/ +1 more | +132 | 0 replies | |
| 1/6 | virtio_ring: virtqueue_add_sgs, to add multiple sgs.drivers/ include/ tools/ +1 more | +132 | 0 replies | |
| 2/6 | virtio_ring: don't count elements twice for add_buf path.drivers/ | +80 | 0 replies | |
| 3/6 | virtio_ring: inline internal vring functions more aggressively.drivers/ | +56 | 2 replies | |
| 4/6 | virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf.drivers/ include/ | +54 | 3 replies | |
| 5/6 | tools/virtio: make vringh_test use inbuf/outbuf.tools/ tools/ | +14 | 0 replies | |
| 6/6 | virtio_scsi: use virtqueue_add_inbuf() for virtscsi_kick_event.drivers/ | +2 | 0 replies |
Reviews trailers per patch
3 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Wanlong Gao | Asias He |
|---|---|---|
| 1/6 | R-b R-b | R-b R-b |
| 1/6 | R-b R-b | R-b R-b |
| 2/6 | R-b | |
| 3/6 | ||
| 4/6 | ||
| 5/6 | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] virtio_add_buf replacement.
OK, so I've spent a few days benchmarking. Turns out 80% of virtio_add_buf cases are uni-directional (including the always-performance-sensitive networking code), and that gets no performance penalty (though tests with real networking would be appreciated!).
I'm not reposting all the "convert driver to virtio_add_outbuf()"
patches: just the scsi one which I didn't have before. I won't actually remove virtio_add_buf() until the *following* merge window, just to be sure.
One annoying thing about benchmarking is that in some cases, speeding up one side can make the whole thing slower, due to more wakeups. Device-side polling techniques might be required in future to get more performance.
Cheers,
Rusty.