Skip to content

cpuset_regression_test: convert and improve

Richard Palethorpe ltp 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [LTP] [PATCH 0/3] cpuset_regression_test: convert and improve

Hello Joerg,

Quoted 8 lines · Joerg Vehlow

Hi,

this is more or less a v2 of a patch I send previously (patch 3). I know that richard is not entirely happy with this patch, I will give it another try anyway...
It is either this patch or another patch, that has to look through the cgroup hierarchy, to check if there is any group,that explicitely uses cpu 0.

If it is already being used then can you set it?

Quoted 8 lines

To me, it is a better solution to just change groups for a short time, and check if the bug exists. If ltp tests are running, the chance, that there is anything running, that really needs a correct cpuset is very low. I am comming from a system, where cgroups are setup by a container launcher, that just happens to assign cpus to the containers - not even exclusively. LTP tests are used as some part of the testsuite, to test as close to a production system as possible.

I was thinking that if you are already using CPU sets then you either don't have the bug or you won't hit it on your setup(s)? If so then the test is redundant.

Quoted 11 lines

The only way I could think of a process misbehaving by disabeling cpu pinning, would be a badly written multithread application, that cannot correctly run, if threads are really running in parallel, but this would also require a scheduling policy, that makes scheduling points predicatable. While I know that software like that exists (in fact I was working on something like that in the past), I think it is highly unlikely, that it is running parallel to ltp.
And even then, this could be mitigated by not just setting cpu binding to undefined, but to one fixed core. But with the changes in patch 2, this is not possible.

Quoted 5 lines

But anyhow ltp fiddles with lots of critical system parameters during it's runtime, there is no guarantee, that an application that requires some very specific kernel runtime settings survives this. That's why I would still vote for this patch.

J?rg

I still think it has a small chance of causing problems for us. There are some heterogeneous CPU systems where control software should run on a given CPU. I don't know whether CGroups are used to control that or if it would matter if the process is moved temporarily. It's just a small risk I would avoid if the test is not really worth it.

OTOH the patch looks good otherwise, so it should be merged if no one else agrees with me.

Signature · 2 lines
Thank you,
Richard.