Wrapping up the vfs support for unprivileged mounts
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 31 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | vfs: Don't allow changing the link count of an inode with an invalid uid or gidfs/ | +10 | 3 replies | |
| 2/6 | vfs: Allow userns root to call mknod on owned filesystems.fs/ | +2 | 6 replies | |
| 3/6 | fs: Allow superblock owner to replace invalid owners of inodesfs/ | +28 | 3 replies | |
| 4/6 | fs: Allow superblock owner to access do_remount_sb()fs/ | +2 | 4 replies | |
| 5/6 | capabilities: Allow privileged user in s_user_ns to set security.* xattrssecurity/ | +6 | 1 reply | |
| 6/6 | fs: Allow CAP_SYS_ADMIN in s_user_ns to freeze and thaw filesystemsfs/ | +2 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Seth Forshee | Eric W. Biederman | Serge Hallyn | Christian Brauner | Dongsu Park |
|---|---|---|---|---|---|
| Series | Inspired-by A-b | A-b | A-b A-b | T-b T-b | |
| 1/6 | A-b A-b | A-b | |||
| 2/6 | A-b A-b | A-b | |||
| 3/6 | Inspired-by A-b Inspired-by A-b Inspired-by A-b | A-b | |||
| 4/6 | A-b | A-b | A-b | ||
| 5/6 | A-b | A-b | |||
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [REVIEW][PATCH 0/6] Wrapping up the vfs support for unprivileged mounts
Very slowly the work has been progressing to ensure the vfs has the necessary support for mounting filesystems without privilege.
This patchset contains one more core piece of that work, ensuring a few more operations that would write back an inode and confuse an exisiting filesystem are denied.
The rest of the changes actually enable userns root to do things with filesystems that the userns root has mounted. Most of these have been waiting in the wings a long time, held back because I wanted the core of the patchset to be solid before I started allowing additional behavor.
It is definitely time for these changes so the effect of s_user_ns becomes less theoretical.
The change to allow mknod is new, but consistent with everything else and harmless as device nodes on filesystems mounted without privilege are ignored.
Unless problems show up in the during review I plan to merge these changes.
These changes are also available at:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git userns-test
Eric W. Biederman (5):
vfs: Don't allow changing the link count of an inode with an invalid uid or gid
vfs: Allow userns root to call mknod on owned filesystems.
fs: Allow superblock owner to replace invalid owners of inodes
fs: Allow superblock owner to access do_remount_sb()
capabilities: Allow privileged user in s_user_ns to set security.* xattrs
Seth Forshee (1):
fs: Allow CAP_SYS_ADMIN in s_user_ns to freeze and thaw filesystems
fs/attr.c | 36 ++++++++++++++++++++++++++++-------- fs/ioctl.c | 4 ++-- fs/namei.c | 16 ++++++++++++---- fs/namespace.c | 4 ++-- security/commoncap.c | 8 ++++++-- 5 files changed, 50 insertions(+), 18 deletions(-)
Eric