Skip to content

Detaching mounts on unlink

Eric W. Biederman containers linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11vfs: Document the effect of d_revalidate on d_find_aliasfs/dcache.c+2 -10 replies
2/11vfs: More precise tests in d_invalidatefs/dcache.c+4 -346 replies
3/11vfs: Don't allow overwriting mounts in the current mount namespacefs/mount.h fs/namei.c fs/namespace.c+51 -15 replies
4/11vfs: Keep a list of mounts on a mount pointfs/mount.h fs/namespace.c+8 -00 replies
5/11vfs: Add a function to lazily unmount all mounts from any dentry.fs/mount.h fs/namespace.c+41 -03 replies
6/11vfs: Lazily remove mounts on unlinked files and directories.fs/dcache.c fs/namei.c+42 -360 replies
7/11vfs: Remove unnecessary calls of check_submounts_and_dropfs/afs/dir.c fs/fuse/dir.c fs/gfs2/dentry.c +2 more+0 -260 replies
8/11vfs: Merge check_submounts_and_drop and d_invalidatefs/dcache.c include/linux/dcache.h+22 -346 replies
9/11vfs: Make d_invalidate return voidfs/btrfs/ioctl.c fs/cifs/readdir.c fs/dcache.c +4 more+13 -290 replies
10/11vfs: Remove d_drop calls from d_revalidate implementationsfs/ceph/dir.c fs/proc/base.c fs/proc/fd.c+0 -70 replies
11/11proc: Update proc_flush_task_mnt to use d_invalidatefs/proc/base.c+2 -40 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMiklos SzerediEric W. Biederman
SeriesR-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b A-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/11] Detaching mounts on unlink

The last round of this patchset the semantics of dropping mounts on unlink were agreed upon so long as we preserve the current semantics in a single mount namespace.

There are two big changes with this version of the patchset.
1) The test for a mount in the current mount namespace has been rewritten so that it is actually correct and is now a drop in replacement for d_mountpoint. Removing the need for code changes that could cause unitended regressions.

2) This work has been comprehensivly extend to d_revalidate and d_invalidate allowing some long standing bugs to be fixed at the end of this patch series.

In net this should result in a kernel that is more comprehensible and maintainble as well as fixing some possible mount leaks, and removing the possibility of DOS attacks from evily placed mount points, in other mount namespaces.

Eric W. Biederman (11):
vfs: Document the effect of d_revalidate on d_find_alias
vfs: More precise tests in d_invalidate
vfs: Don't allow overwriting mounts in the current mount namespace
vfs: Keep a list of mounts on a mount point
vfs: Add a function to lazily unmount all mounts from any dentry.
vfs: Lazily remove mounts on unlinked files and directories.
vfs: Remove unnecessary calls of check_submounts_and_drop
vfs: Merge check_submounts_and_drop and d_invalidate
vfs: Make d_invalidate return void
vfs: Remove d_drop calls from d_revalidate implementations
proc: Update proc_flush_task_mnt to use d_invalidate

 fs/afs/dir.c           |    5 --
 fs/btrfs/ioctl.c       |    5 +--
 fs/ceph/dir.c          |    1 -
 fs/cifs/readdir.c      |    6 +--
 fs/dcache.c            |  140 +++++++++++++++++-------------------------------
 fs/fuse/dir.c          |    7 +--
 fs/gfs2/dentry.c       |    3 -
 fs/kernfs/dir.c        |   11 ----
 fs/mount.h             |   13 +++++
 fs/namei.c             |   28 ++++++----
 fs/namespace.c         |   80 +++++++++++++++++++++++++++
 fs/nfs/dir.c           |    7 +--
 fs/proc/base.c         |   10 +---
 fs/proc/fd.c           |    2 -
 include/linux/dcache.h |    3 +-
 15 files changed, 167 insertions(+), 154 deletions(-)

Eric