Skip to content

exec: s/group_exit_task/group_exec_task/ for clarity

Eric W. Biederman linux-fsdevel lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 0 repliesNew
  2. v12 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6signal: Pretty up the SIGNAL_GROUP_FLAGSinclude/linux/sched/signal.h+9 -70 replies
2/6exec: Lock more defensively in execfs/exec.c+9 -20 replies
3/6signal: Implement SIGNAL_GROUP_DETHREADfs/exec.c include/linux/sched/signal.h+4 -00 replies
4/6signal: In signal_group_exit remove the group_exit_task testinclude/linux/sched/signal.h+3 -20 replies
5/6coredump: Stop using group_exit_taskfs/coredump.c+0 -20 replies
6/6exec: Rename group_exit_task group_exec_task and correct the Documentationfs/exec.c include/linux/sched/signal.h kernel/exit.c+10 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] exec: s/group_exit_task/group_exec_task/ for clarity

There is a variable tsk->signal->group_exit_task that is only truly used in de_thread. These changes modify the coredump code and the signal_group_exit() function to stop using group_exit_task, and rename the group_exit_task variable to group_exec_task.

In addition as I think Linus was asking an additional signal flag is added called SIGNAL_GROUP_DETHREAD, and that flag is used in the function signal_group_exit() so that only signal->flags needs to be tested.

Eric W. Biederman (6):
signal: Pretty up the SIGNAL_GROUP_FLAGS
exec: Lock more defensively in exec
signal: Implement SIGNAL_GROUP_DETHREAD
signal: In signal_group_exit remove the group_exit_task test
coredump: Stop using group_exit_task
exec: Rename group_exit_task group_exec_task and correct the Documentation

 fs/coredump.c                |  2 --
 fs/exec.c                    | 22 ++++++++++++++++------
 include/linux/sched/signal.h | 33 +++++++++++++++++----------------
 kernel/exit.c                |  4 ++--
 4 files changed, 35 insertions(+), 26 deletions(-)