Skip to content

SA1100/PXA RTC clean-up

Robert Jarzmik linux-arm-kernel linux-rtc 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 5/50 of 6 patches 0 repliesNew
  2. v4 posting 4/50 of 6 patches 0 repliesSuperseded
  3. v4 posting 3/50 of 6 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v4 posting 2/50 of 6 patches0 repliesSuperseded
v4 posting 1/50 of 6 patches0 repliesSuperseded

Patches in v4 posting 5/5 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/6] SA1100/PXA RTC clean-up
Quoted 15 lines · Rob Herring
Quoted 3 lines

On platforms where all the OSes use only 1 RTC, the bootloader only touches one RTC, that's correct. Or said differently : the bootloader touches the union of all the RTCs the OSes it launches do touch.

Sorry, I'm being dense here, but I'm not any less confused as to which scenarios you think have an issue. Rather than go around again on this, perhaps you can just provide the warning for the commit text. Here's what I have.

8<------------------------------------------------------------------- From e43db14b27486faef8d8e74e4aa555aba7f31a0e Mon Sep 17 00:00:00 2001
From: Rob Herring <[email protected]>
Date: Mon, 1 Jun 2015 07:53:01 -0500
Subject: [PATCH] ARM: config: Switch PXA27x platforms to use PXA RTC driver

Quoted 6 lines

With the SA1100 and PXA RTC drivers be mutually exclusive and no longer sharing hardware, PXA27x/PXA3xx platforms must use the PXA RTC driver as the SA1100 platform device is no longer registered.

This change should be transparent to userspace, but the first reboot after the switch will have the wrong time.

I'll switch that last sentence to :
"This change should be almost transparent to userspace. Former users of pxa-rtc should be aware that 2 rtc will be available on their kernels, rtc0 being sa1100-rtc and rtc1 being pxa-rtc. Any userspace relying on the fact that rtc0 was pxa-rtc should be fixed.

As a consequence :
- the first reboot after the switch will have the wrong time,
- on dual boot platform where the other OS programs some logic into the sa1100 rtc IP, a lack of fix in userspace, ie. a kernel changing sa1100-rtc thinking it is pxa-rtc could have dire consequence, such as wiping the other OS data partition.
"

And add :
Cc: Mike Rapoport <[email protected]>
Cc: Philipp Zabel <[email protected]>

With that, I'll be happy. I'll throw this serie at my jenkins, but there's no reason for it to complain, and unless I've forgotten some unaddressed comment, you'll have my ack within the next couple of days.

Cheers.

--
Robert