Skip to content

RFC: PCI using capabilitities

Rusty Russell kvm linux-arch lkml virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 92 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11virtio: use u32, not bitmap for struct virtio_device's featuresdrivers/char/virtio_console.c drivers/lguest/lguest_device.c drivers/s390/kvm/kvm_virtio.c +8 more+18 -390 replies
2/11virtio: add support for 64 bit features.drivers/char/virtio_console.c drivers/lguest/lguest_device.c drivers/s390/kvm/kvm_virtio.c +7 more+36 -330 replies
3/11pci: add pci_iomap_rangeinclude/asm-generic/io.h include/asm-generic/iomap.h lib/iomap.c+51 -53 replies
4/11virtio-pci: define layout for virtio vendor-specific capabilities.include/linux/virtio_pci.h+41 -01 reply
6/11virtio_pci: move old defines to legacy, introduce new structure.drivers/virtio/Kconfig drivers/virtio/Makefile drivers/virtio/virtio_pci_legacy.c +1 more+62 -310 replies
6/11virtio_pci: don't use the legacy driver if we find the new PCI capabilities.drivers/virtio/virtio_pci_legacy.c include/linux/virtio_pci.h+39 -13 replies
7/11virtio_pci: new, capability-aware driver.drivers/virtio/Makefile drivers/virtio/virtio_pci.c+870 -073 replies
8/11virtio_pci: share structure between legacy and modern.drivers/virtio/virtio_pci-common.h drivers/virtio/virtio_pci.c drivers/virtio/virtio_pci_legacy.c+105 -1510 replies
9/11virtio_pci: share interrupt/notify handlers between legacy and modern.drivers/virtio/Makefile drivers/virtio/virtio_pci-common.c drivers/virtio/virtio_pci-common.h +2 more+133 -1600 replies
10/11virtio_pci: share virtqueue setup/teardown between modern and legacy driver.drivers/virtio/virtio_pci-common.c drivers/virtio/virtio_pci-common.h drivers/virtio/virtio_pci.c +1 more+291 -4300 replies
11/11virtio_pci: simplify common helpers.drivers/virtio/virtio_pci-common.c drivers/virtio/virtio_pci-common.h drivers/virtio/virtio_pci.c +1 more+36 -430 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/11] RFC: PCI using capabilitities

Here's the patch series I ended up with. I haven't coded up the QEMU side yet, so no idea if the new driver works.

Questions:
(1) Do we win from separating ISR, NOTIFY and COMMON?
(2) I used a "u8 bar"; should I use a bir and pack it instead? BIR seems a little obscure (noone else in the kernel source seems to refer to it).

Cheers,
Rusty.