Skip to content

ipv4: tcp_memcontrol and userns sysctls

Eric W. Biederman cgroups containers netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tcp_memcontrol: Remove tcp_max_memoryinclude/net/tcp_memcontrol.h net/ipv4/tcp_memcontrol.c+0 -140 replies
2/6tcp_memcontrol: Remove setting cgroup settings via sysctlinclude/net/tcp_memcontrol.h net/ipv4/sysctl_net_ipv4.c net/ipv4/tcp_memcontrol.c+2 -520 replies
3/6tcp_memcontrol: Remove the per netns control.include/net/netns/ipv4.h include/net/tcp.h net/ipv4/af_inet.c +6 more+21 -340 replies
3/6tcp_memcontrol: Remove the per netns control.include/net/netns/ipv4.h include/net/tcp.h net/ipv4/af_inet.c +6 more+21 -340 replies
4/6tcp_memcontrol: Kill struct tcp_memcontrolinclude/net/sock.h include/net/tcp_memcontrol.h mm/memcontrol.c +1 more+35 -700 replies
5/6ipv4: Use math to point per net sysctls into the appropriate struct net.net/ipv4/sysctl_net_ipv4.c+5 -180 replies
6/6ipv4: Allow unprivileged users to use per net sysctlsnet/ipv4/sysctl_net_ipv4.c+0 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] ipv4: tcp_memcontrol and userns sysctls

While looking into allowing the ipv4 sysctls to be used in a network namespace I stumbled upon the mess that is tcp_memcontrol.

I remove the dead code, broken code, and excessive abstraction in the tcp_memcontrols then I clean up up and allow in the user namespace the per net ipv4 sysctls.

Eric W. Biederman (6):
tcp_memcontrol: Remove tcp_max_memory
tcp_memcontrol: Remove setting cgroup settings via sysctl
tcp_memcontrol: Remove the per netns control.
tcp_memcontrol: Kill struct tcp_memcontrol
ipv4: Use math to point per net sysctls into the appropriate struct net.
ipv4: Allow unprivileged users to use per net sysctls

 include/net/netns/ipv4.h     |    1 -
 include/net/sock.h           |   28 ++++++------
 include/net/tcp.h            |    3 +-
 include/net/tcp_memcontrol.h |   12 ------
 mm/memcontrol.c              |    6 +-
 net/ipv4/af_inet.c           |    2 -
 net/ipv4/sysctl_net_ipv4.c   |   85 ++++++----------------------------------
 net/ipv4/tcp.c               |   12 +++--
 net/ipv4/tcp_ipv4.c          |    1 +
 net/ipv4/tcp_memcontrol.c    |   90 ++++++++---------------------------------
 net/ipv6/af_inet6.c          |    2 -
 net/ipv6/tcp_ipv6.c          |    1 +
 12 files changed, 57 insertions(+), 186 deletions(-)

Eric