Skip to content

ARM: OMAP2+: AM33XX: VDD CORE OPP50 support

Kevin Hilman linux-arm-kernel linux-devicetree linux-omap 6 versions – New

Get series with b4
b4 am CAGa+x86XVetqMGMTh7LoX6VAEb-d0W67_SbgTCxk4Q=QovpKTQ@mail.gmail.com

Versions newest first · linked by author and title

  1. v4 Latest posting 6/60 of 4 patches 0 repliesNew
  2. v4 posting 5/60 of 4 patches 0 repliesSuperseded
  3. v4 posting 4/60 of 4 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v4 posting 3/60 of 4 patches0 repliesSuperseded
v4 posting 2/60 of 4 patches0 repliesSuperseded
v4 posting 1/60 of 4 patches0 repliesSuperseded

Patches in v4 posting 6/6 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] ARM: OMAP2+: AM33XX: VDD CORE OPP50 support
Quoted 8 lines · Russ Dill
Quoted 7 lines · Kevin Hilman

Well, I was thinking of something much dumber.

I was thinking about just _carefully_ writing a single, self-contained C function, with all of its data on the stack (and consts as #defines). Think of it is a step up in readability from straight assembly (which was the stated reason for moving the code to the M3 in the first place.)

Quoted 5 lines
Quoted 1 line

Kevin

That can only give you your suspend function. You need a resume function to undo everything before calling cpu_resume, and the resume function needs access to the data that was in the suspend function.

Well, it can be done (and I've seen it done) with various hacks, but I agree it's not pretty, but it is at least slightly prettier than piles of asm. That being said, I saw you posted a more generic solution that looks like a real solution that can scale. I'll have a closer look at that. Thanks for working on it.

Kevin