Skip to content

user namespace fixes

Eric W. Biederman containers lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Fix cap_capable to only allow owners in the parent user namespace to have caps.security/commoncap.c+17 -80 replies
2/4userns: Require CAP_SYS_ADMIN for most uses of setns.fs/namespace.c ipc/namespace.c kernel/pid_namespace.c +2 more+10 -53 replies
3/4userns: Add a more complete capability subset test to commit_credskernel/cred.c+25 -15 replies
3/4userns: Add a more complete capability subset test to commit_credskernel/cred.c+26 -14 replies
4/4userns: Fix typo in description of the limitation of userns_installkernel/user_namespace.c+1 -13 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSerge HallynAndy Lutomirski
SeriesA-b A-b
1/4A-b
2/4A-b A-b A-b
3/4A-b A-b A-b A-b A-b A-b
3/4A-b A-b A-b A-b A-b A-b
4/4A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] user namespace fixes

These are fixes from Andys review of my user namespace tree.

The first two patches are critical must fix fixes.

The third patch fixing commit_creds is a nice to have but fixing it would be good.

Andy, Serge if you could give these patches a once over to make certain I am not doing something stupid.

Thank you,
Eric

---

Eric W. Biederman (4):
Fix cap_capable to only allow owners in the parent user namespace to have caps.
userns: Require CAP_SYS_ADMIN for most uses of setns.
userns: Add a more complete capability subset test to commit_creds
userns: Fix typo in description of the limitation of userns_install

 fs/namespace.c           |    3 ++-
 ipc/namespace.c          |    3 ++-
 kernel/cred.c            |   26 +++++++++++++++++++++++++-
 kernel/pid_namespace.c   |    3 ++-
 kernel/user_namespace.c  |    2 +-
 kernel/utsname.c         |    3 ++-
 net/core/net_namespace.c |    3 ++-
 security/commoncap.c     |   25 +++++++++++++++++--------
 8 files changed, 53 insertions(+), 15 deletions(-)