Skip to content

devpts: fix devpts mount behavior

Eric W. Biederman containers lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4devpts: Remove CONFIG_DEVPTS_MULTIPLE_INSTANCESDocumentation/filesystems/devpts.txt drivers/tty/Kconfig fs/devpts/inode.c+13 -620 replies
2/4devpts: Set the default permissions of /dev/pts/ptmx and /dev/ptmx to 0666drivers/tty/pty.c drivers/tty/tty_io.c fs/devpts/inode.c +1 more+9 -130 replies
3/4devpts: Make the newinstance option historicaldrivers/tty/pty.c fs/devpts/inode.c include/linux/devpts_fs.h+77 -1127 replies
4/4devpts: Update the documentationDocumentation/filesystems/devpts.txt+22 -660 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchSerge E. Hallyn
1/4A-b
2/4A-b
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] devpts: fix devpts mount behavior

This is the restart of an old conversation that started out with Serge noting that there are problems taking advantage of the devpts newinstance mount option. As the conversation progressed it was suggested that the devpts newinstance mount option should just be removed if possible. Then the conversation floundered upon what to do about /dev/ptmx. Making /dev/ptmx a symlink sounds simple, but in practice no one could actually figure out how to make it happen.

I was playing with this recently and it is not at all hard or complicated to have opens of ptmx redirect themselves to pts/ptmx.

So I propose we solve this issue by adding a little magic to /dev/ptmx and making the devpts newinstance mount option historical.

I my limited testing the code just works.

I assume that since devpts is essentially serial this should go through Greg's tree?

Eric