Skip to content

pvcreate & detection of foreign signatures

Petr Rockai lvm-devel 1 version New

Get series with b4
b4 am [email protected].

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchPetr Rockai
SeriesR-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] pvcreate & detection of foreign signatures

Hi,

Quoted 5 lines · Milan Broz

After the third report of broken LUKS after pvcreate (just this week...) I added LUKS detection to lvm. But the current code is messy and in fact it wipes superblocks without asking by default.

This is attempt to change that to something more user friendly.

Looks OK to me. I am trusting you on the LUKS detection bit, the rest

Quoted 15 lines

Milan Broz (4):
Change the pvcreate swap/md logic
Remove assumption that --ye must be used only in --force mode Fix file open leak in swap signature detection Detect LUKS signature in pvcreate

 lib/Makefile.in         |    1 +
 lib/device/dev-luks.c   |   43 ++++++++++++++++++++++++++++
 lib/device/dev-swap.c   |   12 +++----
 lib/device/device.h     |    1 +
 lib/metadata/metadata.c |   71 +++++++++++++++++++++++++----------------------
 tools/pvremove.c        |    5 ---
 tools/toollib.c         |    5 ---
 7 files changed, 88 insertions(+), 50 deletions(-)
 create mode 100644 lib/device/dev-luks.c