per signal_struct coredumps
Get series with b4
b4 am 87v92qx2c6.fsf@disp2133Versions newest first
- v1 Latest6 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | signal: Remove the bogus sigkill_pending in ptrace_stopkernel/ | +4 | 3 replies | |
| 2/6 | ptrace: Remove the unnecessary arguments from arch_ptrace_stoparch/ arch/ include/ +1 more | +17 | 1 reply | |
| 2/6 | ptrace: Remove the unnecessary arguments from arch_ptrace_stoparch/ arch/ include/ +1 more | +17 | 0 replies | |
| 3/6 | exec: Check for a pending fatal signal instead of core_statefs/ | +6 | 1 reply | |
| 4/6 | exit: Factor coredump_exit_mm out of exit_mmfs/ kernel/ mm/ | +47 | 1 reply | |
| 5/6 | coredump: Don't perform any cleanups before dumping corefs/ include/ kernel/ +3 more | +20 | 3 replies | |
| 6/6 | coredump: Limit coredumps to a single thread groupfs/ fs/ fs/ +5 more | +32 | 4 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Kees Cook |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] per signal_struct coredumps
Current coredumps are mixed up with the exit code, the signal handling code and with the ptrace code in was they are much more complicated than necessary and difficult to follow.
This series of changes starts with ptrace_stop and cleans it up, making it easier to follow what is happening in ptrace_stop. Then cleans up the exec interactions with coredumps.
Then cleans up the coredump interactions with exit.
Then the coredump interactions with the signal handling code is clean up.
The first and last changes are bug fixes for minor bugs.
I believe the fact that vfork followed by execve can kill the process the called vfork if exec fails is sufficient justification to change the userspace visible behavior.
In previous conversations it was suggested that some of these cleanups did not stand on their own. I think I have managed to organize things so all of their patches stand on their own.
Which means that if for some reason the last change needs to be reverted we can still keep the gains from the other changes.
Eric W. Biederman (6):
signal: Remove the bogus sigkill_pending in ptrace_stop
ptrace: Remove the unnecessary arguments from arch_ptrace_stop
exec: Check for a pending fatal signal instead of core_state
exit: Factor coredump_exit_mm out of exit_mm
coredump: Don't perform any cleanups before dumping core
coredump: Limit coredumps to a single thread group
arch/ia64/include/asm/ptrace.h | 4 +- arch/sparc/include/asm/ptrace.h | 8 ++-- fs/binfmt_elf.c | 4 +- fs/binfmt_elf_fdpic.c | 2 +- fs/coredump.c | 88 ++++++----------------------------------- fs/exec.c | 14 +++---- fs/proc/array.c | 6 +-- include/linux/mm_types.h | 13 ------ include/linux/ptrace.h | 22 +++++------ include/linux/sched.h | 1 + include/linux/sched/signal.h | 13 ++++++ kernel/exit.c | 76 +++++++++++++++++++---------------- kernel/fork.c | 4 +- kernel/signal.c | 49 ++++------------------- mm/oom_kill.c | 6 +-- 15 files changed, 104 insertions(+), 206 deletions(-)
Eric