Skip to content

RFC exec_update_mutex related cleanups

Eric W. Biederman lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elfarch/x86/ia32/ia32_aout.c fs/binfmt_aout.c fs/binfmt_elf_fdpic.c +1 more+4 -64 replies
2/3exec: Make unlocking exec_update_mutex explictfs/exec.c include/linux/binfmts.h+4 -53 replies
3/3exec: Rename the flag called_exec_mmap point_of_no_returnfs/exec.c include/linux/binfmts.h+9 -92 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKees CookChristian Brauner
SeriesA-b
1/3A-b A-b
2/3R-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC][PATCH 0/3] exec_update_mutex related cleanups

Linus,

Since you rightly pointed out the code in fs/exec.c is less readable than it should be right now. Here is where I currently sit on making that code static where possible and as obvious as possible.

I will resend this after the merge window for a proper review when people are less likely to be distrcacted but I figured I might as well send this out now so I can see if anyone runs screaming from this code.

Eric W. Biederman (3):
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
exec: Make unlocking exec_update_mutex explict
exec: Rename the flag called_exec_mmap point_of_no_return

 arch/x86/ia32/ia32_aout.c |  3 +--
 fs/binfmt_aout.c          |  2 +-
 fs/binfmt_elf_fdpic.c     |  2 +-
 fs/binfmt_flat.c          |  3 +--
 fs/exec.c                 | 18 +++++++++---------
 include/linux/binfmts.h   |  7 +++----
 6 files changed, 16 insertions(+), 19 deletions(-)

Eric