Skip to content

siginfo cleanups for x86

Eric W. Biederman kvm linux-arch lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 33 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20signal: Simplify tracehook_report_syscall_exitarch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/traps.c arch/x86/include/asm/ptrace.h +3 more+24 -281 reply
2/20signal/x86: Inline fill_sigtrap_info in it's only caller send_sigtraparch/x86/kernel/ptrace.c+7 -153 replies
3/20signal/x86: Move MCE error reporting out of force_sig_info_faultarch/x86/mm/fault.c+11 -122 replies
4/20signal/x86: Use send_sig_mceerr as apropriatearch/x86/kvm/mmu.c+1 -102 replies
5/20signal/x86: In trace_mpx_bounds_register_exception add __user annotationsarch/x86/include/asm/trace/mpx.h+2 -21 reply
6/20signal/x86: Move mpx siginfo generation into do_boundsarch/x86/include/asm/mpx.h arch/x86/kernel/traps.c arch/x86/mm/mpx.c+33 -293 replies
7/20signal/x86/traps: Factor out show_signalarch/x86/kernel/traps.c+19 -181 reply
8/20signal/x86/traps: Move setting error_code and trap_nr into do_trap_no_signalarch/x86/kernel/traps.c+14 -154 replies
9/20signal/x86/traps: Use force_sig_bnderrarch/x86/kernel/traps.c+9 -101 reply
10/20signal/x86/traps: Use force_sig instead of open coding it.arch/x86/kernel/traps.c+1 -11 reply
11/20signal/x86/traps: Simplify trap generationarch/x86/kernel/traps.c+24 -611 reply
12/20signal/x86: Remove pkey parameter from bad_area_nosemaphorearch/x86/mm/fault.c+7 -73 replies
13/20signal/x86: Remove the pkey parameter from do_sigbusarch/x86/mm/fault.c+3 -31 reply
14/20signal/x86: Remove pkey parameter from mm_fault_errorarch/x86/mm/fault.c+2 -21 reply
15/20signal/x86: Don't compute pkey in __do_page_faultarch/x86/mm/fault.c+0 -41 reply
16/20signal/x86: Pass pkey not vma into __bad_areaarch/x86/mm/fault.c+7 -111 reply
17/20signal/x86: Call force_sig_pkuerr from __bad_area_nosemaphorearch/x86/mm/fault.c+23 -521 reply
18/20signal/x86: Replace force_sig_info_fault with force_sig_faultarch/x86/mm/fault.c+4 -191 reply
19/20signal/x86: Pass pkey by valuearch/x86/mm/fault.c+7 -71 reply
20/20signal/x86: Use force_sig_fault where appropriatearch/x86/entry/vsyscall/vsyscall_64.c arch/x86/kernel/ptrace.c arch/x86/kernel/traps.c +1 more+9 -321 reply

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchThomas GleixnerPaolo Bonzini
1/20R-b
2/20R-b
3/20R-b
4/20R-b A-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b R-b
9/20R-b
10/20R-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20R-b
16/20R-b
17/20R-b
18/20R-b
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [REVIEW][PATCH 00/20] siginfo cleanups for x86

I have been slowly going thought and reworking the arch specific functions that generate siginfo. The problems I have been addressing is that using siginfo directly is error prone. Using siginfo directly makes it easy to leave fields initialized, and get confused about which fields need to be filled in.

To address this I have added a series of helper functions to kernel/signal.c, that are specific to exactly one use of struct siginfo and take the parameters they need.

To use these functions the x86 signal handling needs some cleanups but the net result appears to be less code that is easier to follow.

If while looking over these patches you see anything please let me know. I don't think I missed something but to err is human.

Likewise if you would like to merge these patches via the tip tree let me know. Otherwise after the review is complete I plan on merging these into my siginfo tree. At this point I believe all of the prerequisite patches are merged so it should not make a difference.

Eric W. Biederman (20):
signal: Simplify tracehook_report_syscall_exit
signal/x86: Inline fill_sigtrap_info in it's only caller send_sigtrap signal/x86: Move MCE error reporting out of force_sig_info_fault signal/x86: Use send_sig_mceerr as apropriate
signal/x86: In trace_mpx_bounds_register_exception add __user annotations signal/x86: Move mpx siginfo generation into do_bounds signal/x86/traps: Factor out show_signal
signal/x86/traps: Move setting error_code and trap_nr into do_trap_no_signal signal/x86/traps: Use force_sig_bnderr
signal/x86/traps: Use force_sig instead of open coding it. signal/x86/traps: Simplify trap generation
signal/x86: Remove pkey parameter from bad_area_nosemaphore signal/x86: Remove the pkey parameter from do_sigbus signal/x86: Remove pkey parameter from mm_fault_error signal/x86: Don't compute pkey in __do_page_fault
signal/x86: Pass pkey not vma into __bad_area
signal/x86: Call force_sig_pkuerr from __bad_area_nosemaphore signal/x86: Replace force_sig_info_fault with force_sig_fault signal/x86: Pass pkey by value
signal/x86: Use force_sig_fault where appropriate

 arch/powerpc/include/asm/ptrace.h     |   2 +-
 arch/powerpc/kernel/traps.c           |   7 +-
 arch/x86/entry/vsyscall/vsyscall_64.c |   9 +-
 arch/x86/include/asm/mpx.h            |  13 ++-
 arch/x86/include/asm/ptrace.h         |   2 +-
 arch/x86/include/asm/trace/mpx.h      |   4 +-
 arch/x86/kernel/ptrace.c              |  29 ++----
 arch/x86/kernel/traps.c               | 175 ++++++++++++++--------------------
 arch/x86/kernel/umip.c                |   8 +-
 arch/x86/kvm/mmu.c                    |  11 +--
 arch/x86/mm/fault.c                   | 161 +++++++++++--------------------
 arch/x86/mm/mpx.c                     |  30 ++----
 include/linux/ptrace.h                |  17 ++--
 include/linux/tracehook.h             |  13 +--
 14 files changed, 175 insertions(+), 306 deletions(-)

Eric