Skip to content

Use rsvg-convert for SVG --> PDF conversion

Akira Yokosawa perfbook 1 version Applied

Status from this message: Applied both, thank you!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 of 8 patches 8 repliesApplied

7 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
2/8Makefile: Don't use rsvg-convert < 2.57Makefile+12 -40 replies
3/8Makefile: Allow rsvg-convert 2.52Makefile+13 -10 replies
4/8Makefile: Use rsvg-convert anyway if no inkscape is foundMakefile+3 -00 replies
5/8cartoons: Retouch r-2014-Memory-barrier.svgcartoons/r-2023-Memory-barrier.svg cpu/overview.tex+1131 -10 replies
6/8FAQ-BUILD: List package for rsvg-convert in package listsFAQ-BUILD.txt+19 -40 replies
7/8docker: Add packages for rsvg-convertdocker/Dockerfile docker/Dockerfile.fedora+4 -70 replies
8/8gitlab-ci.yml: Install librsvg instead of inkscapeutilities/gitlab-ci.yml+1 -14 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchLeonardo Bras
2/8
3/8
4/8
5/8
6/8
7/8
8/8T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -perfbook 0/8] Use rsvg-convert for SVG --> PDF conversion

Hi Paul,

[Cc 0/8 and 8/8 to Leo, Patch 8/8 touches gitlab-ci.yml]

Frequent crashes of Inkscape I encountered in 2023, which was mitigated in commit f307e19f2be0 ("Prevent inkscape from interacting with desktop manager"), made me look into alternative SVG --> PDF converters.

It turns out that recent versions of rsvg-convert work reasonably well for perfbook. By "recent versions", I mean 2.52.5 and 2.57.x. rsvg-convert is a light-weight CLI command and is much faster than inkscape.

Sequential SVG --> PDF conversion time I get from
"make cleanfigs-svg; env time make figs":

elapsed

Inkscape:        21.45s
rsvg-convert:     6.05s

So patches 1/8--4/8 add rules in Makefile for using rsvg-convert if it is recent enough.

One caveat: There is a SVG cartoon drawn by an ancient version of Inkscape, for which very recent versions of rsvg-convert produce distorted background of outlined text.

Patch 5/8 retouches the cartoon and put a SVG compatible with librsvg as cartoons/r-2023-Memory-barriers.svg.

Patches 6/8 and 7/8 adjust FAQ-BUILD and Dockerfiles accordingly.

Patch 8/8 updates gitlab-ci.yml. It needs an explicit ACK or Tested-by:
from Leo before applying.

Finally, this series wouldn't affect those of you who don't have rsvg-convert.

Thanks, Akira
--
Akira Yokosawa (8):
Makefile: Add rules to use rsvg-convert for SVG --> PDF conversion
Makefile: Don't use rsvg-convert < 2.57
Makefile: Allow rsvg-convert 2.52
Makefile: Use rsvg-convert anyway if no inkscape is found
cartoons: Retouch r-2014-Memory-barrier.svg
FAQ-BUILD: List package for rsvg-convert in package lists
docker: Add packages for rsvg-convert
gitlab-ci.yml: Install librsvg instead of inkscape

 FAQ-BUILD.txt                      |   23 +-
 Makefile                           |   48 +-
 cartoons/r-2023-Memory-barrier.svg | 1130 ++++++++++++++++++++++++++++
 cpu/overview.tex                   |    2 +-
 docker/Dockerfile                  |    4 +-
 docker/Dockerfile.fedora           |    7 +-
 utilities/gitlab-ci.yml            |    2 +-
 7 files changed, 1198 insertions(+), 18 deletions(-)
 create mode 100644 cartoons/r-2023-Memory-barrier.svg

base-commit: 1ea46c6d43475fbdf97404dec28a58036d505bc3

Signature · 1 line
2.34.1