New uid & gid mount option parsing helpers
Status from this message: Applied to the vfs.mount.api branch of the vfs/vfs.git tree.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
Reviews trailers per patch
3 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Hans de Goede | Steven Rostedt (Google) | Ian Kent |
|---|---|---|---|
| 1/14 | |||
| 2/14 | A-b | ||
| 3/14 | |||
| 4/14 | |||
| 5/14 | |||
| 6/14 | |||
| 7/14 | |||
| 8/14 | |||
| 9/14 | |||
| 10/14 | |||
| 11/14 | |||
| 12/14 | |||
| 13/14 | A-b | ||
| 14/14 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/14] New uid & gid mount option parsing helpers
Multiple filesystems take uid and gid as options, and the code to create the ID from an integer and validate it is standard boilerplate that can be moved into common helper functions, so do that for consistency and less cut&paste.
This also helps avoid the buggy pattern noted by Seth Jenkins at
https://lore.kernel.org/lkml/CALxfFW4BXhEwxR0Q5LSkg-8Vb4r2MONKCcUCVioehXQKr35eHg@mail.gmail.com/
because uid/gid parsing will fail before any assignment in most filesystems.
Net effect is a bit of code removal, as well.
Patch 1 is the infrastructure change, then per-fs conversions follow, cc'd as appropriate.
This series is also at
https://git.kernel.org/pub/scm/linux/kernel/git/sandeen/linux.git/log/?h=mount-api-uid-helper
Thanks,
-Eric
Documentation/filesystems/mount_api.rst | 9 +++++++-- fs/autofs/inode.c | 16 ++++------------ fs/debugfs/inode.c | 16 ++++------------ fs/efivarfs/super.c | 12 ++++-------- fs/exfat/super.c | 8 ++++---- fs/ext4/super.c | 22 ++++------------------ fs/fs_parser.c | 34 ++++++++++++++++++++++++++++++++++ fs/fuse/inode.c | 12 ++++-------- fs/hugetlbfs/inode.c | 12 ++++-------- fs/isofs/inode.c | 16 ++++------------ fs/ntfs3/super.c | 12 ++++-------- fs/smb/client/fs_context.c | 39 ++++++++++++--------------------------- fs/tracefs/inode.c | 16 ++++------------ include/linux/fs_parser.h | 6 +++++- mm/shmem.c | 12 ++++-------- 15 files changed, 102 insertions(+), 140 deletions(-)