Skip to content

r8169: improve RTL8168g PHY suspend quirk

Heiner Kallweit netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2r8169: move ERI access functions to avoid forward declarationdrivers/net/ethernet/realtek/r8169_main.c+64 -640 repliesApplied
2/2r8169: improve RTL8168g PHY suspend quirkdrivers/net/ethernet/realtek/r8169_main.c+26 -260 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] r8169: improve RTL8168g PHY suspend quirk

According to Realtek the ERI register 0x1a8 quirk is needed to work around a hw issue with the PHY on RTL8168g. The register needs to be changed before powering down the PHY. Currently we don't meet this requirement, however I'm not aware of any problems caused by this. Therefore I see the change as an improvement.

The PHY driver has no means to access the chip ERI registers, therefore we have to intercept MDIO writes to the BMCR register. If the BMCR_PDOWN bit is going to be set, then let's apply the quirk before actually powering down the PHY.

Heiner Kallweit (2):
r8169: move ERI access functions to avoid forward declaration
r8169: improve RTL8168g PHY suspend quirk

 drivers/net/ethernet/realtek/r8169_main.c | 180 +++++++++++-----------
 1 file changed, 90 insertions(+), 90 deletions(-)
Signature · 1 line
2.30.0