Skip to content

w1 fixes for broken subsystem

Hans-Frieder Vogt lkml 1 version In review

Get series with b4
b4 am 9348473.dVMUCnY2zF@maximilian

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2w1 - fix fops in w1_bus_notifydrivers/w1/w1.c+3 -00 replies
2/2w1 - call request_module with w1 master mutex unlockeddrivers/w1/w1.c+3 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEvgeniy Polyakov
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] w1 fixes for broken subsystem

In recent kernels the 1-wire kernel modules do not work any more. The module wire got broken in 3.11-rc1 and 3.12-rc1 introduced a further problem:

1: 3.11-rc1 introduced the automatic loading of slave modules. This blocks modprobe, because request_module is called with a locked mutex of the w1 master.
Loading of the slave module calls w1_register_family, which calls in turn w1_reconnect_slaves and there mutex_lock(&dev->mutex) will wait forever....

2: 3.12-rc1 introduced w1_bus_notify which assumes that all slaves have fops defined. This is not the case for e.g. w1_smem and maybe also breaks custom written modules.

This very small patch set is split in 2 parts:

PATCH 1/2: w1 - fix fops in w1_bus_notify
fixes problem 2 above

PATCH 2/2: w1 - call request_module with w1 master mutex unlocked fixes problem 1 above

Please include these patches in 3.12-rc4 and in 3.11 stable.

Best regards,

Hans-Frieder Vogt e-mail: hfvogt <at> gmx .dot. net