Skip to content

SubmittingPatches: update and flesh out trailer sections

[email protected] git 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesNew
  2. v25 patches 2 repliesSuperseded
  3. v16 patches 11 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5SubmittingPatches: encourage trailer use for substantial helpDocumentation/SubmittingPatches+11 -30 replies
2/5SubmittingPatches: discourage common Linux trailersDocumentation/SubmittingPatches+4 -00 replies
3/5SubmittingPatches: document Based-on-patch-by trailerDocumentation/SubmittingPatches+4 -00 replies
4/5SubmittingPatches: be consistent with trailer markupDocumentation/SubmittingPatches+7 -70 replies
5/5SubmittingPatches: note that trailer order mattersDocumentation/SubmittingPatches+10 -00 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchThe ReviewerThe (Late) ReviewerJunio C Hamano
1/5
2/5
3/5
4/5
5/5A-b A-b Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] SubmittingPatches: update and flesh out trailer sections

From: Kristoffer Haugsbakk <[email protected]>

Topic name (applied) kh/submittingpatches-trailers

Topic summary: Flesh out and update the trailer sections.

All of these points have come up on the mailing list. At least for me. And Based-on-patch-by is a nice-to-have documented kind of thing.

[elide “since January” from v1...]

Link to v2: https://lore.kernel.org/git/[email protected]/

§ Changes in v3

Patch “encourage trailer use for substantial help”: correct AsciiDoc anchor placement.

[1/5] SubmittingPatches: encourage trailer use for substantial help [2/5] SubmittingPatches: discourage common Linux trailers [3/5] SubmittingPatches: document Based-on-patch-by trailer [4/5] SubmittingPatches: be consistent with trailer markup [5/5] SubmittingPatches: note that trailer order matters

 Documentation/SubmittingPatches | 46 ++++++++++++++++++++++++++-------
 1 file changed, 36 insertions(+), 10 deletions(-)

Interdiff against v2:

Documentation/SubmittingPatches +1 -1
index dceeb5a1817..56706e55ea1 100644
@@ -447,8 +447,8 @@ identifying, and not misleading.
 The goal of this policy is to allow us to have sufficient information to contact
 you if questions arise about your contribution.
 
-=== Commit trailers
 [[commit-trailers]]
+=== Commit trailers
 It is polite to credit people who have helped with your work to a
 substantial enough degree. This project uses commit trailers for that,
 where the credited person is written out like a Git author, i.e. with

Range-diff against v2:
1: 835eb736f39 ! 1: dc75b862d73 SubmittingPatches: encourage trailer use for substantial help
@@ Commit message

## Documentation/SubmittingPatches ##
-@@ Documentation/SubmittingPatches: identifying, and not misleading.
- The goal of this policy is to allow us to have sufficient information to contact
+@@ Documentation/SubmittingPatches: The goal of this policy is to allow us to have sufficient information to contact
you if questions arise about your contribution.

-+=== Commit trailers
[[commit-trailers]]
-If you like, you can put extra trailers at the end:
++=== Commit trailers
+It is polite to credit people who have helped with your work to a +substantial enough degree. This project uses commit trailers for that, +where the credited person is written out like a Git author, i.e. with

2:  5a652b8e14d = 2:  86b9973a8e8 SubmittingPatches: discourage common Linux trailers
3:  5e53999b2e9 = 3:  a142f66c3b8 SubmittingPatches: document Based-on-patch-by trailer
4:  dd47fabe917 = 4:  439fa864da7 SubmittingPatches: be consistent with trailer markup
5:  726386d976b = 5:  2d133f2ad5e SubmittingPatches: note that trailer order matters

base-commit: 1ff279f3404a482a83fb04c7457e41ab26884aea

Signature · 1 line
2.54.0.22.g9e26862b904