RFC coredump cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest13 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | restore 32bit aout coredumparch/ | +36 | 0 replies | |
| 2/13 | new helper: dump_emit()fs/ fs/ include/ +1 more | +41 | 0 replies | |
| 3/13 | switch elf_core_write_extra_phdrs() to dump_emit()arch/ arch/ fs/ +3 more | +15 | 0 replies | |
| 4/13 | switch elf_core_write_extra_data() to dump_emit()arch/ arch/ fs/ +2 more | +11 | 0 replies | |
| 5/13 | binfmt_elf: convert writing actual dump pages to dump_emit()fs/ | +3 | 0 replies | |
| 6/13 | convert the rest of binfmt_elf_fdpic to dump_emit()fs/ | +31 | 0 replies | |
| 7/13 | switch elf_coredump_extra_notes_write() to dump_emit()arch/ arch/ arch/ +3 more | +30 | 0 replies | |
| 8/13 | aout: switch to dump_emitarch/ fs/ | +11 | 0 replies | |
| 9/13 | binfmt_elf: count notes towards coredump limitfs/ | +0 | 0 replies | |
| 10/13 | make dump_emit() use vfs_write() instead of banging at ->f_op->write directlyfs/ | +12 | 6 replies | |
| 11/13 | dump_skip(): dump_seek() replacement taking coredump_paramsarch/ fs/ fs/ +3 more | +22 | 1 reply | |
| 12/13 | spufs: get rid of dump_emit() wrappersarch/ | +20 | 0 replies | |
| 13/13 | new helper: dump_align()arch/ fs/ fs/ +2 more | +12 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC][PATCH 00/13] coredump cleanups
This series tries to regularize the coredump writes/seeks/rlimit handling
etc. Quite a bit of boilerplate code removed, another open-coded caller of ->write() converted to use of normal codepath (which was the original reason I've got into that mess). RLIMIT_CORE handling got a lot more uniform, short writes handling fixed (we had weird cases where a very large ->write() to pipe might happen and where short write had been treated as an error).
It needs more testing; I don't have any test setups that could deal
with spufs, for example, and while it seems to produce normal coredumps on what I have tested, I'd still like more eyes on it.
The same series is in the tip of vfs.git#experimental, so if you prefer
git access for review...
Shortlog:
restore 32bit aout coredump
new helper: dump_emit()
switch elf_core_write_extra_phdrs() to dump_emit()
switch elf_core_write_extra_data() to dump_emit()
binfmt_elf: convert writing actual dump pages to dump_emit() convert the rest of binfmt_elf_fdpic to dump_emit()
switch elf_coredump_extra_notes_write() to dump_emit()
aout: switch to dump_emit
binfmt_elf: count notes towards coredump limit
make dump_emit() use vfs_write() instead of banging at ->f_op->write directly dump_skip(): dump_seek() replacement taking coredump_params
spufs: get rid of dump_emit() wrappers
new helper: dump_align()
Diffstat:
arch/ia64/kernel/elfcore.c | 12 +-- arch/powerpc/include/asm/spu.h | 3 +- arch/powerpc/platforms/cell/spu_syscalls.c | 5 +- arch/powerpc/platforms/cell/spufs/coredump.c | 89 ++++++-------------- arch/powerpc/platforms/cell/spufs/spufs.h | 3 +- arch/x86/ia32/ia32_aout.c | 86 ++++++++++---------- arch/x86/um/elfcore.c | 15 +--- fs/binfmt_aout.c | 9 +- fs/binfmt_elf.c | 84 ++++++------------- fs/binfmt_elf_fdpic.c | 114 +++++++------------------- fs/coredump.c | 64 +++++++++------ include/linux/binfmts.h | 1 + include/linux/coredump.h | 6 +- include/linux/elf.h | 6 +- include/linux/elfcore.h | 7 +- kernel/elfcore.c | 10 +-- 16 files changed, 196 insertions(+), 318 deletions(-)