Skip to content

inotify tests for v5.9 regression

Petr Vorel ltp 1 version New

Get series with b4
b4 am X9xv+6e0tJgVDN/9@pevik

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3syscalls/inotify10: Generalize for more test cases+0 -00 replies
2/3syscalls/inotify10: Add test cases with two groups+0 -00 replies
3/3syscalls/inotify10: Test two inotify groups with parent and child watches+0 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPetr Vorel
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [LTP] [PATCH 0/3] inotify tests for v5.9 regression

Hi Amir,

Quoted 4 lines

Hi Petr,

Here is the test for the other v5.9 regression that I mentioned earlier. The fix commit has just been merged to master.

Thanks for your patch, LGTM. I'll probably merge it later today.

Quoted 11 lines

History:
Originally, inotify10 was written to cover a bug that was detected during the review of the fsnotify changes for v5.9, but was not merged to v5.9. Later, I wrote test case #3 to cover another bug that was merged to v5.9. While testing the v5.9-bug-fix in linux-next, Hugh Dickins reported [1] a bug introduced by the v5.9-bug-fix, so I added two more test cases to cover the bug-in-the-bug-fix.
The bug-in-the-bug-fix was fixed before the v5.9-bug-fix was merged.

Long story short, the only test case expected to fail is test case #3 on kernel >= v5.9 and now fixed in master :-)

Correct, it fails on my openSUSE 5.10.0-rc5 kernel.
I tested it on someold kernels (patched 4.4; 4.9) and on some newer ones (5.8.14 and on current devel SLES kernel).

BTW interesting (nothing to be fixed in the test) that second commit slower down on newer kernels (0,200s), while on old kernels is the same (0.010s).

Kind regards,
Petr

Quoted 13 lines

Thanks,
Amir.

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/

Amir Goldstein (3):
syscalls/inotify10: Generalize for more test cases syscalls/inotify10: Add test cases with two groups syscalls/inotify10: Test two inotify groups with parent and child
watches

 testcases/kernel/syscalls/inotify/inotify10.c | 126 ++++++++++++++----
 1 file changed, 98 insertions(+), 28 deletions(-)