Skip to content

RFC Various mtk_eth_soc cleanups

Russell King (Oracle) linux-arm-kernel linux-mediatek netdev 1 version New

Get series with b4
b4 am Y/ivHGroIVTe4YP/@shell.armlinux.org.uk

Versions newest first

  1. v1 RFC Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchSimon Horman
SeriesR-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC net-next 0/4] Various mtk_eth_soc cleanups

Hi,

These are a number of patches that do a bit of cleanup to mtk_eth_soc, including one (the last) which seems to indicate that I somehow missed adding RMII and REVMII to the supported_interfaces - but no one has complained, and checking the DT files in the kernel, no one uses these modes (so the driver is probably untested for these.)

The first patch cleans up mtk_gmac0_rgmii_adjust(), which is the troublesome function preventing the driver becoming a post-March2020 phylink driver. It doesn't solve that problem, merely makes the code easier to follow by getting rid of repeated tenary operators.

The second patch moves the check for DDR2 memory to the initialisation of phylink's supported_interfaces - if TRGMII is not possible for some reason, we should not be erroring out in phylink MAC operations when that can be determined prior to phylink creation.

The third patch removes checks from mtk_mac_config() that are done when initialising supported_interfaces - phylink will not call mtk_mac_config() with an interface that was not marked as supported, so these checks are redundant.

The last patch adds comments for REVMII and RMII. As I note, these seem to be unused in the DT files, and as no one has reported that these don't work, I suggest that no one uses them. Should we drop support for these modes, or add them to supported_interfaces?

Please review, and I'll collect attributations for resending after net-next has re-opened.

Thanks.

 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 71 ++++++++++++++---------------
 1 file changed, 34 insertions(+), 37 deletions(-)
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!