Skip to content

RFC Libclang based analyzer

Petr Vorel ltp 1 version New

Get series with b4
b4 am YLnvOpNr3HlTLWWP@pevik

Versions newest first

  1. v1 RFC Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [LTP] [RFC PATCH 0/2] Libclang based analyzer

Hi Richie,

Quoted 7 lines
Quoted 2 lines

FYI yesterday I sent patch to add make check{,-c,shell}, but for running C/shell API tests:
https://patchwork.ozlabs.org/project/ltp/list/?series=247103

So I guess we have a name collision here. Something to consider is that GNU Make defines 'checks' as running self tests. So perhaps you are correct to use that word.

Quoted 5 lines

I could rename the static analyses to 'analyze' or 'lint'. OTOH it might be better if running the self tests is called 'make run-{c,shell}-api-tests', because only a few people need to do that. Whereas it is intended that all contributors run the static analyses checks.

run-{c,shell}-api-tests is IMHO too long, but I was thinking about check-{,c,shell}-api. But maybe you're right, let's wait for others opinions.

Quoted 2 lines

Although, if someone runs 'make check' in the lib directory, then it makes sense to run the C API tests as well as do the analyses. Or not?

Yes, I'd be for having make check, which would run all check targets, which can be also run separately:
make check-clang
make check-c
make check-shell

(or whatever we name these clang and C/shell API tests targets)

Quoted 6 lines
Quoted 4 lines

Taking 2 latests commits + adding clang-devel / libclang-dev packages makes CI running.

https://github.com/pevik/ltp/commit/b2427f39ddb15c97761208a605637e0da6fe66ca

Thanks, I guess this shows that libclang is well supported.

Yes, it looks to be even in old clang 3.5.

Quoted 19 lines
Quoted 19 lines

The only missing piece is include/mk/clang-checks.mk (this patchset not even compile now).

Quoted 2 lines

Richard Palethorpe (2):
Add 'make checks' and clang-checks to build system

make check ... clang-check (to avoid confusion).

Quoted 12 lines

Start libclang based analyzer and TEST() check

 configure.ac                       |   2 +
 include/mk/config.mk.in            |   5 +
 include/mk/env_post.mk             |   8 ++
 include/mk/generic_leaf_target.inc |   5 +-
 include/mk/lib.mk                  |   3 +
 include/mk/rules.mk                |   9 ++
 include/mk/testcases.mk            |   1 +
 tools/clang-checks/.gitignore      |   1 +
 tools/clang-checks/Makefile        |  13 ++
 tools/clang-checks/main.c          | 218 +++++++++++++++++++++++++++++
Quoted 5 lines
Quoted 2 lines

I'd name it tools/clang-check/ (and include/mk/clang-check.mk), but that's just personal opinion.

Yeah, we do not want a mixture of check and checks. I should probably just make it 'check' as it saves typing one letter.

+1

Kind regards,
Petr