Skip to content

Add TST_NET_IPV{4, 6}_ONLY and use on broken_ip

Petr Vorel ltp 1 version New

Get series with b4
b4 am YPAizWCKXQHQOSBv@pevik

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [LTP] [PATCH 0/2] Add TST_NET_IPV{4, 6}_ONLY and use on broken_ip
Quoted 17 lines · Petr Vorel
Quoted 6 lines

Hi Alexey,

https://github.com/linux-test-project/ltp/issues/843

does it make sense to run it on IPv4 and broken_ip-totlen on IPv6? Both don't break but not in runtest file.

Hi Petr,

Yes it should work with the -L option, but these tests are the same (differs the descriptions for IPv4/IPv6):

diff -u broken_ip-plen broken_ip-totlen

broken_ip-totlen line 16

Quoted 8 lines
broken_ip-totlen renamed from broken_ip-plen +1 -1
@@ -10,7 +10,7 @@
 
 do_test()
 {
-	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong payload len for $NS_DURATION sec"
+	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong total len field for $NS_DURATION sec"
 	tst_icmp -t $NS_DURATION -s "0 100 500 1000 $NS_ICMP_SENDER_DATA_MAXSIZE" -L
 	tst_ping
 }

Good catch, thanks!

Quoted 1 line

So broken_ip-totlen should be just removed.

I merged commit which implements this.

Kind regards,
Petr