Skip to content

some small range-diff read_patches() fixes

Jeff King git 1 version In review

Get series with b4
b4 am YRGwGDvOte/[email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3range-diff: drop useless "offset" variable from read_patches()range-diff.c+2 -20 replies
2/3range-diff: handle unterminated lines in read_patches()range-diff.c+11 -140 replies
3/3range-diff: use ssize_t for parsed "len" in read_patches()range-diff.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] some small range-diff read_patches() fixes

Amidst all the talk of clang4 in another thread, I noticed that Debian unstable recently shipped a clang-14 package. So I tried it out, and it does find one small cleanup. And then looking at the surrounding code helped me find 2 more. :)

[1/3]: range-diff: drop useless "offset" variable from read_patches() [2/3]: range-diff: handle unterminated lines in read_patches() [3/3]: range-diff: use ssize_t for parsed "len" in read_patches()

 range-diff.c | 29 +++++++++++++----------------
 1 file changed, 13 insertions(+), 16 deletions(-)

-Peff