Skip to content

New API: Rename LTP_IPC_PATH -> TST_IPC_PATH

Petr Vorel ltp 1 version New

Get series with b4
b4 am YSYIt9TqTBU0AVKk@pevik

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [LTP] [PATCH 0/3] New API: Rename LTP_IPC_PATH -> TST_IPC_PATH
Quoted 11 lines

Hi!

Quoted 4 lines

Petr Vorel (3):
lib: Move IPC_ENV_VAR definition into header
C API: Rename LTP_IPC_PATH -> TST_IPC_PATH
shell API: Rename LTP_IPC_PATH -> TST_IPC_PATH

Is this really a good idea?

As it is it's pretty clear where the environment variable comes from, if we rename it to TST_IPC_PATH it's not obvious that this has been exported by LTP test.

I was thinking about it as well (just forget to write that into cover letter).

Quoted 2 lines

Generally things that are visible on the running system tends to be prefixed with LTP_ or ltp_ rather than TST_ or tst_...

Sure. I just thought that LTP_ is for variables which are expected to be set by user. But let's keep the old name. How about the first commit (cleanup)?

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/wiki/User-Guidelines