Skip to content

net: ethernet: mtk_eth_soc: refactoring and Clause 45

Daniel Golle linux-arm-kernel linux-mediatek lkml netdev 5 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest3 patches 0 repliesApplied
  2. v113 patches 0 repliesSuperseded
  3. v103 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v93 patches1 replySuperseded
v83 patches0 repliesSuperseded

Patches in v12 Applied

#Subject and filesSizeRepliesApplied
1/3net: ethernet: mtk_eth_soc: fix return values and refactor MDIO opsdrivers/net/ethernet/mediatek/mtk_eth_soc.c drivers/net/ethernet/mediatek/mtk_eth_soc.h+41 -280 replies
2/3net: mdio: add helpers to extract clause 45 regad and devad fieldsinclude/linux/mdio.h+12 -00 replies
3/3net: ethernet: mtk_eth_soc: implement Clause 45 MDIO accessdrivers/net/ethernet/mediatek/mtk_eth_soc.c drivers/net/ethernet/mediatek/mtk_eth_soc.h+60 -130 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchDaniel GolleAndrew Lunn
1/3
2/3T-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [PATCH v12 0/3] net: ethernet: mtk_eth_soc: refactoring and Clause 45

Rework value and type of mdio read and write functions in mtk_eth_soc and generally clean up and unify both functions.
Then add support to access Clause 45 phy registers, using newly introduced helper macros added by a patch Russell King has suggested in a reply to an earlier version of this series [1].

All three commits are tested on the Bananapi BPi-R64 board having MediaTek MT7531BE DSA gigE switch using clause 22 MDIO and Ubiquiti UniFi 6 LR access point having Aquantia AQR112C PHY using clause 45 MDIO.

[1]: https://lore.kernel.org/netdev/[email protected]/

v12: replace 'ret != 0' forgotten from an earlier iteration with
'ret < 0' checks of mtk_mdio_busy_wait return value (purely cosmetical as anyway either 0 or -ETIMEDOUT is returned, sorry for the noise)
v11: also address return value of mtk_mdio_busy_wait
v10: correct order of SoB lines in 2/3, change patch order in series
v9: improved formatting and Cc missing maintainer
v8: add patch from Russel King, switch to bitfield helper macros
v7: remove unneeded variables and order OR-ed call parameters
v6: further clean up functions and more cleanly separate patches
v5: fix wrong variable name in first patch covered by follow-up patch
v4: clean-up return values and types, split into two commits
v3: return -1 instead of 0xffff on error in _mtk_mdio_write
v2: use MII_DEVADDR_C45_SHIFT and MII_REGADDR_C45_MASK to extract
device id and register address. Unify read and write functions to have identical types and parameter names where possible as we are anyway already replacing both function bodies.

Daniel Golle (2):
net: ethernet: mtk_eth_soc: fix return values and refactor MDIO ops
net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access

Russell King (Oracle) (1):
net: mdio: add helpers to extract clause 45 regad and devad fields

 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 101 +++++++++++++++-----
 drivers/net/ethernet/mediatek/mtk_eth_soc.h |  19 +++-
 include/linux/mdio.h                        |  12 +++
 3 files changed, 102 insertions(+), 30 deletions(-)
Signature · 1 line
2.34.1