Skip to content

CanoKey: Fix xHCI compatibility and CCID ZLP

Hongren (Zenithal) Zheng qemu-devel 2 versions – In review

Get series with b4
b4 am YqcptnhfCtUn2+T6@Sun

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

* use usb_ep_get instead of recording ep_in_pointer as suggested by kraxel
* CI result for v2 is at
https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/562306905

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/usb/canokey: Fix CCID ZLPhw/usb/canokey.c+3 -40 replies
2/3hw/usb/canokey: fix compatibility of qemu-xhcihw/usb/canokey.c+23 -00 replies
3/3docs/system/devices/usb/canokey: remove limitations on qemu-xhcidocs/system/devices/canokey.rst+0 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] CanoKey: Fix xHCI compatibility and CCID ZLP

In patch v5 [1] of Introduce CanoKey QEMU I said that canokey-qemu was incompatible with qemu-xhci.

kraxel kindly suggested[2] that it should be the problem of usb_wakeup So I fixed it in this patch set.

Now that the v5 patch has been in the process of git PULL [3], I think it would be better to post a new patch set instead of sending out v6, which would make maintainer's tree back and forth.

This patch should be applied after [1].

As for the CCID ZLP issue, it is described in the comment and commit message.

I added a commit in https://github.com/canokeys/canokey-qemu
to export the EP num in the header, so hw/usb/canokey.c in qemu could use it for CTAPHID quirks. If you want to compile this version when --enable-canokey, make sure to use the latest libcanokey-qemu.so

The CI result for this PATCH is at [4]. The failure for amd64-debian-container seems irrelevent to this patchset.

[1] https://lore.kernel.org/qemu-devel/YoY5k0PQny8WtAHi@Sun/
[2] https://lore.kernel.org/qemu-devel/[email protected]/
[3] https://lore.kernel.org/qemu-devel/[email protected]/
[4] https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/561801062

---
v2:
* use usb_ep_get instead of recording ep_in_pointer as suggested by kraxel
* CI result for v2 is at
https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/562306905

Hongren (Zenithal) Zheng (3):
hw/usb/canokey: Fix CCID ZLP
hw/usb/canokey: fix compatibility of qemu-xhci docs/system/devices/usb/canokey: remove limitations on qemu-xhci

 docs/system/devices/canokey.rst | 10 ----------
 hw/usb/canokey.c                | 30 ++++++++++++++++++++++++++----
 2 files changed, 26 insertions(+), 14 deletions(-)
Signature · 1 line
2.35.1